Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964877AbbGHJEu (ORCPT ); Wed, 8 Jul 2015 05:04:50 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:45889 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933028AbbGHJEs (ORCPT ); Wed, 8 Jul 2015 05:04:48 -0400 Date: Wed, 8 Jul 2015 11:04:27 +0200 From: Peter Zijlstra To: Arthur Marsh Cc: Mathieu Desnoyers , linux-kernel@vger.kernel.org, Rusty Russell , rostedt , Oleg Nesterov , "Paul E. McKenney" Subject: Re: lock-up with module: Optimize __module_address() using a latched RB-tree Message-ID: <20150708090427.GY3644@twins.programming.kicks-ass.net> References: <20150706100447.GX3644@twins.programming.kicks-ass.net> <559A545A.80508@internode.on.net> <20150706103246.GY3644@twins.programming.kicks-ass.net> <559B63A2.4030601@internode.on.net> <20150707072951.GM3644@twins.programming.kicks-ass.net> <1736781680.1883.1436286785932.JavaMail.zimbra@efficios.com> <559C3371.2030704@internode.on.net> <20150707215620.GM19282@twins.programming.kicks-ass.net> <20150707221122.GU18673@twins.programming.kicks-ass.net> <559CDFE1.7060503@internode.on.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <559CDFE1.7060503@internode.on.net> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 937 Lines: 26 On Wed, Jul 08, 2015 at 06:01:29PM +0930, Arthur Marsh wrote: > > > Peter Zijlstra wrote on 08/07/15 07:41: > >On Tue, Jul 07, 2015 at 11:56:20PM +0200, Peter Zijlstra wrote: > > >Could you try the below? It appears there was a spot freeing modules > >that forgot to take them out of the tree. > > > >If that fails, try and disable CONFIG_MODULE_UNLOAD. > > I tried the patch below, re-built and installed and booted the kernel and > saw: > > http://www.users.on.net/~arthur.marsh/20150708471.jpg > http://www.users.on.net/~arthur.marsh/20150708472.jpg Ah, that's a lockdep splat, caused by Mathieu's patch. Did the system boot otherwise? Maybe take that patch from Mathieu out again. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/