Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934602AbbGHKYJ (ORCPT ); Wed, 8 Jul 2015 06:24:09 -0400 Received: from foss.arm.com ([217.140.101.70]:40015 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932862AbbGHKYF (ORCPT ); Wed, 8 Jul 2015 06:24:05 -0400 Date: Wed, 8 Jul 2015 11:23:43 +0100 From: Mark Rutland To: Mars Cheng Cc: Matthias Brugger , CC Hwang , Loda Chou , Miles Chen , Scott Shu , Jades Shih , Yingjoe Chen , MY Chuang , "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "devicetree@vger.kernel.org" Subject: Re: [PATCH 2/2] arm64: dts: mediatek: add mt6795 support Message-ID: <20150708102343.GC7025@leverpostej> References: <1436350480-17276-1-git-send-email-mars.cheng@mediatek.com> <1436350480-17276-3-git-send-email-mars.cheng@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436350480-17276-3-git-send-email-mars.cheng@mediatek.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5547 Lines: 198 On Wed, Jul 08, 2015 at 11:14:40AM +0100, Mars Cheng wrote: > This adds basic chip support for MT6795 SoC > > Signed-off-by: Mars Cheng > --- > arch/arm64/boot/dts/mediatek/Makefile | 1 + > arch/arm64/boot/dts/mediatek/mt6795-evb.dts | 34 ++++++ > arch/arm64/boot/dts/mediatek/mt6795.dtsi | 164 ++++++++++++++++++++++++++++ > 3 files changed, 199 insertions(+) > create mode 100644 arch/arm64/boot/dts/mediatek/mt6795-evb.dts > create mode 100644 arch/arm64/boot/dts/mediatek/mt6795.dtsi > > diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile > index 3ce2462..e0a4bff 100644 > --- a/arch/arm64/boot/dts/mediatek/Makefile > +++ b/arch/arm64/boot/dts/mediatek/Makefile > @@ -1,3 +1,4 @@ > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt6795-evb.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-evb.dtb > > always := $(dtb-y) > diff --git a/arch/arm64/boot/dts/mediatek/mt6795-evb.dts b/arch/arm64/boot/dts/mediatek/mt6795-evb.dts > new file mode 100644 > index 0000000..3a43c860 > --- /dev/null > +++ b/arch/arm64/boot/dts/mediatek/mt6795-evb.dts > @@ -0,0 +1,34 @@ > +/* > + * Copyright (c) 2015 MediaTek Inc. > + * Author: Mars.C > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ > + > +/dts-v1/; > +#include "mt6795.dtsi" > + > +/ { > + model = "MediaTek MT6795 Evaluation Board"; > + > + memory@40000000 { > + device_type = "memory"; > + reg = <0 0x40000000 0 0x1e800000>; > + }; > + > + chosen { > + bootargs = "console=ttyS0,921600n8 earlyprintk"; PLease get rid of bootargs here; earlyprintk doesn't do anything on arm64 (it's earlycon these days), and you can specify the serial configuration in stdout-path, so please use that instead. > + stdout-path = &uart0; > + }; > +}; > + > +&uart0 { > + status = "okay"; > +}; > diff --git a/arch/arm64/boot/dts/mediatek/mt6795.dtsi b/arch/arm64/boot/dts/mediatek/mt6795.dtsi > new file mode 100644 > index 0000000..832be20 > --- /dev/null > +++ b/arch/arm64/boot/dts/mediatek/mt6795.dtsi > @@ -0,0 +1,164 @@ > +/* > + * Copyright (c) 2015 MediaTek Inc. > + * Author: Mars.C > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ > + > +#include > +#include > + > +/ { > + compatible = "mediatek,mt6795"; > + interrupt-parent = <&sysirq>; > + #address-cells = <2>; > + #size-cells = <2>; > + > + cpus { > + #address-cells = <1>; > + #size-cells = <0>; > + > + cpu0: cpu@0 { > + device_type = "cpu"; > + compatible = "arm,cortex-a53"; > + reg = <0x000>; > + }; > + > + cpu1: cpu@1 { > + device_type = "cpu"; > + compatible = "arm,cortex-a53"; > + reg = <0x001>; > + }; No enable-method? Does your FW patch that in? > + > + cpu2: cpu@2 { > + device_type = "cpu"; > + compatible = "arm,cortex-a53"; > + reg = <0x002>; > + }; > + > + cpu3: cpu@3 { > + device_type = "cpu"; > + compatible = "arm,cortex-a53"; > + reg = <0x003>; > + }; > + > + cpu4: cpu@4 { > + device_type = "cpu"; > + compatible = "arm,cortex-a53"; > + reg = <0x100>; > + }; The unit-address should match the reg (e.g. this should be cpu@100). > + > + cpu5: cpu@5 { > + device_type = "cpu"; > + compatible = "arm,cortex-a53"; > + reg = <0x101>; > + }; > + > + cpu6: cpu@6 { > + device_type = "cpu"; > + compatible = "arm,cortex-a53"; > + reg = <0x102>; > + }; > + > + cpu7: cpu@7 { > + device_type = "cpu"; > + compatible = "arm,cortex-a53"; > + reg = <0x103>; > + }; > + }; > + > + clocks { > + system_clk: dummy13m { > + compatible = "fixed-clock"; > + clock-frequency = <13000000>; > + #clock-cells = <0>; > + }; > + > + rtc_clk: dummy32k { > + compatible = "fixed-clock"; > + clock-frequency = <32000>; > + #clock-cells = <0>; > + }; > + > + uart_clk: dummy26m { > + compatible = "fixed-clock"; > + clock-frequency = <26000000>; > + #clock-cells = <0>; > + }; > + }; Get rid of the clocks node and place these directly under the root node. > + > + timer { > + compatible = "arm,armv8-timer"; > + interrupt-parent = <&gic>; > + interrupts = + (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, > + + (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, > + + (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, > + + (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>; > + }; The mask is wrong. Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/