Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758522AbbGHKo2 (ORCPT ); Wed, 8 Jul 2015 06:44:28 -0400 Received: from mail.emea.novell.com ([130.57.118.101]:59578 "EHLO mail.emea.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756953AbbGHKoZ (ORCPT ); Wed, 8 Jul 2015 06:44:25 -0400 Date: Wed, 8 Jul 2015 12:44:16 +0200 (CEST) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Gabriele Mazzotta cc: benjamin.tissoires@redhat.com, aduggan@synaptics.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] HID: i2c-hid: Call device suspend callback before disabling irq In-Reply-To: <2307888.TWO9u1uPK9@xps13> Message-ID: References: <1436299082-3526-1-git-send-email-gabriele.mzt@gmail.com> <2307888.TWO9u1uPK9@xps13> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 832 Lines: 22 On Wed, 8 Jul 2015, Gabriele Mazzotta wrote: > i2c-hid takes care of requesting and handling IRQs for HID devices > which in turns might expect them to be always active when working > in normal conditions. Hence, disabling IRQs before calling the suspend > callbacks can potentially cause problems since device drivers might > try to perform operations needing them. > > Fix this by disabling IRQs only after the suspend callbacks had been > executed. That's much nicer changelog, thanks. I've now applied the patch with this changelog to for-4.3/i2c-hid. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/