Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758630AbbGHKrb (ORCPT ); Wed, 8 Jul 2015 06:47:31 -0400 Received: from cantor2.suse.de ([195.135.220.15]:43218 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758530AbbGHKr2 (ORCPT ); Wed, 8 Jul 2015 06:47:28 -0400 Message-ID: <559CFFBE.80801@suse.de> Date: Wed, 08 Jul 2015 12:47:26 +0200 From: Hannes Reinecke User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Bjorn Helgaas , Kashyap Desai , Uday Lingala , Sumit Saxena CC: megaraidlinux.pdl@avagotech.com, linux-scsi@vger.kernel.org, "James E.J. Bottomley" , linux-kernel@vger.kernel.org, Joe Perches , Christoph Hellwig Subject: Re: [PATCH v3 2/3] megaraid_sas : use dev_printk when possible References: <20150707204916.6218.37871.stgit@bhelgaas-glaptop2.roam.corp.google.com> <20150707205233.6218.13548.stgit@bhelgaas-glaptop2.roam.corp.google.com> In-Reply-To: <20150707205233.6218.13548.stgit@bhelgaas-glaptop2.roam.corp.google.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1505 Lines: 40 On 07/07/2015 10:52 PM, Bjorn Helgaas wrote: > Use dev_printk() when possible to make messages more useful. > > Signed-off-by: Bjorn Helgaas > --- > drivers/scsi/megaraid/megaraid_sas_base.c | 304 +++++++++++++-------------- > drivers/scsi/megaraid/megaraid_sas_fusion.c | 95 ++++---- > 2 files changed, 196 insertions(+), 203 deletions(-) > [ .. ] > @@ -1873,8 +1872,8 @@ static int megasas_get_ld_vf_affiliation_111(struct megasas_instance *instance, > cmd = megasas_get_cmd(instance); > > if (!cmd) { > - printk(KERN_DEBUG "megasas: megasas_get_ld_vf_affiliation_111:" > - "Failed to get cmd for scsi%d.\n", > + dev_printk(KERN_DEBUG, &instance->pdev->dev, "megasas_get_ld_vf_affiliation_111:" > + "Failed to get cmd for scsi%d\n", > instance->host->host_no); > return -ENOMEM; > } Makes one wonder why we don't have a 'dev_debug'; dev_notice() and dev_warn() are there ... Otherwise: Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/