Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933476AbbGHLCz (ORCPT ); Wed, 8 Jul 2015 07:02:55 -0400 Received: from foss.arm.com ([217.140.101.70]:40204 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933256AbbGHLC3 (ORCPT ); Wed, 8 Jul 2015 07:02:29 -0400 Message-ID: <559D0342.2040805@arm.com> Date: Wed, 08 Jul 2015 12:02:26 +0100 From: Marc Zyngier Organization: ARM Ltd User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Thomas Gleixner CC: Bjorn Helgaas , Jiang Liu , Jason Cooper , "linux-arm-kernel@lists.infradead.org" , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Yijing Wang , Ma Jun , Lorenzo Pieralisi Subject: Re: [PATCH v3 09/15] irqchip: gicv3-its: Split PCI/MSI code from the core ITS driver References: <1436289485-28230-1-git-send-email-marc.zyngier@arm.com> <1436289485-28230-10-git-send-email-marc.zyngier@arm.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1226 Lines: 43 On 08/07/15 11:48, Thomas Gleixner wrote: > On Tue, 7 Jul 2015, Marc Zyngier wrote: >> +static int its_pci_msi_prepare(struct irq_domain *domain, struct device *dev, >> + int nvec, msi_alloc_info_t *info) >> +{ >> + struct pci_dev *pdev; >> + struct its_pci_alias dev_alias; >> + >> + if (!dev_is_pci(dev)) >> + return -EINVAL; >> + >> + pdev = to_pci_dev(dev); >> + dev_alias.pdev = pdev; >> + dev_alias.count = nvec; >> + >> + pci_for_each_dma_alias(pdev, its_get_pci_alias, &dev_alias); >> + >> + return its_msi_prepare(domain, dev_alias.dev_id, dev_alias.count, info); > > I don't think you need its_msi_prepare() exposed to child > drivers. Something like > > domain->parent->ops->msi_prepare() > > should do the trick. Good point. I've so far conveniently avoided having an extra set of msi_domain_ops at the ITS level itself, but that is starting to look like a mistake. I'll work something out. Thanks, M. -- Jazz is not dead. It just smells funny... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/