Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934797AbbGHLjh (ORCPT ); Wed, 8 Jul 2015 07:39:37 -0400 Received: from mx0a-0016f401.pphosted.com ([67.231.148.174]:64051 "EHLO mx0a-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934240AbbGHLje (ORCPT ); Wed, 8 Jul 2015 07:39:34 -0400 Date: Wed, 8 Jul 2015 19:38:42 +0800 From: Jisheng Zhang To: Russell King - ARM Linux CC: , , , , , , Subject: Re: [PATCH 4/4] arm: psci: add cpuidle_ops support Message-ID: <20150708193842.1ca1c55a@xhacker> In-Reply-To: <20150708103429.GL7557@n2100.arm.linux.org.uk> References: <1436350417-6712-1-git-send-email-jszhang@marvell.com> <1436350417-6712-5-git-send-email-jszhang@marvell.com> <20150708103429.GL7557@n2100.arm.linux.org.uk> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-07-08_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 kscore.is_bulkscore=0 kscore.compositescore=1 compositescore=0.9 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 kscore.is_spamscore=0 rbsscore=0.9 spamscore=0 urlsuspectscore=0.9 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1506180000 definitions=main-1507080189 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1691 Lines: 57 Dear Russell, On Wed, 8 Jul 2015 11:34:29 +0100 Russell King - ARM Linux wrote: > On Wed, Jul 08, 2015 at 06:13:37PM +0800, Jisheng Zhang wrote: > > This patch implements cpuidle_ops using psci. After this patch, we can use > > cpuidle-arm.c with psci backend for both arm and arm64. > > I really don't see the point of most of the patches in this series. > > To summarise, what you're doing is: > > 1. Renaming arch/arm/kernel/psci_smp.c to arch/arm/kernel/psci.c > 2. Adding a #ifdef CONFIG_SMP around _all_ the code in psci.c > 3. Adding cpuidle code with an #ifdef CONFIG_CPU_IDLE around all the > CPU idle code. > > So, we end up with a file which contains: > > /* > header > */ > #include statements > > /* > some commentry relevant to SMP code > */ > #ifdef CONFIG_CPU_IDLE > ... cpu idle code ... > #endif > #ifdef CONFIG_SMP > ... smp code ... > #endif > > which (a) is a mess, and (b) is unnecessary. The only relevant bits which > are shared are the #include statements. > > Please try this alternative approach: > > 1. Leave psci_smp.c alone. > 2. Add arch/arm/kernel/psci_cpuidle.c containing the #include statements > you need, and the CPU idle code. > > I think such an approach will reduce your patch series to two patches, > one moving the ARM64 code, and one adding the cpuidle code. > Good idea! Will refine the patches as you suggested. Thanks a lot for your review, Jisheng -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/