Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758434AbbGHMKk (ORCPT ); Wed, 8 Jul 2015 08:10:40 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:49153 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758118AbbGHMKj (ORCPT ); Wed, 8 Jul 2015 08:10:39 -0400 Date: Wed, 8 Jul 2015 14:10:29 +0200 From: Peter Zijlstra To: Chunyan Zhang Cc: rostedt@goodmis.org, mingo@redhat.com, mathieu.poirier@linaro.org, serge.broslavsky@linaro.org, broonie@kernel.org, alexander.shishkin@linux.intel.com, zhang.lyra@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v3 1/4] STM trace event: Adding generic buffer interface driver Message-ID: <20150708121029.GE12596@twins.programming.kicks-ass.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 578 Lines: 12 On Tue, Jul 07, 2015 at 06:10:40PM +0800, Chunyan Zhang wrote: > +config STM_TRACE_EVENT > + tristate "Redirect/copy the output from kernel trace event to STM engine" How does tristate make sense here? You're using it unconditionally for in-kernel tracepoints. This must be bool, which in turn makes the whole STM thing bool afaiu. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/