Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933316AbbGHMcA (ORCPT ); Wed, 8 Jul 2015 08:32:00 -0400 Received: from casper.infradead.org ([85.118.1.10]:56332 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933153AbbGHMb4 (ORCPT ); Wed, 8 Jul 2015 08:31:56 -0400 Date: Wed, 8 Jul 2015 14:31:48 +0200 From: Peter Zijlstra To: Chunyan Zhang Cc: rostedt@goodmis.org, mingo@redhat.com, mathieu.poirier@linaro.org, serge.broslavsky@linaro.org, broonie@kernel.org, alexander.shishkin@linux.intel.com, zhang.lyra@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v3 4/4] trace: Trace log handler for logging into STM blocks Message-ID: <20150708123148.GF12596@twins.programming.kicks-ass.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1074 Lines: 29 On Tue, Jul 07, 2015 at 06:10:43PM +0800, Chunyan Zhang wrote: > Add the function 'trace_event_stm_output_##call' for printing events > trace log into STM blocks. > > This patch also adds a function call at where the events have been > committed to ring buffer to export the trace event information to > STM blocks. So then you have two copies of the data, why that? Would a scheme were data either goes to the STM or the regular buffer not make much more sense? > +++ b/include/trace/perf.h > @@ -175,6 +175,7 @@ trace_event_raw_event_##call(void *__data, proto) \ > { assign; } \ > \ > trace_event_buffer_commit(&fbuffer); \ > + trace_event_stm_log(&fbuffer); \ This makes every trace event slower. > } > /* > * The ftrace_test_probe is compiled out, it is only here as a build time check -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/