Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758311AbbGHMtK (ORCPT ); Wed, 8 Jul 2015 08:49:10 -0400 Received: from mga11.intel.com ([192.55.52.93]:28049 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757897AbbGHMtI (ORCPT ); Wed, 8 Jul 2015 08:49:08 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,431,1432623600"; d="scan'208";a="758323152" From: Alexander Shishkin To: Chunyan Zhang Cc: Greg Kroah-Hartman , "linux-kernel\@vger.kernel.org" , mathieu.poirier@linaro.org, peter.lachner@intel.com, norbert.schulz@intel.com, keven.boell@intel.com, yann.fouassier@intel.com, laurent.fert@intel.com, "linux-api\@vger.kernel.org" Subject: Re: [PATCH v3 01/11] stm class: Introduce an abstraction for System Trace Module devices In-Reply-To: References: <1436177344-16751-1-git-send-email-alexander.shishkin@linux.intel.com> <1436177344-16751-2-git-send-email-alexander.shishkin@linux.intel.com> User-Agent: Notmuch/0.20.1 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Wed, 08 Jul 2015 15:49:03 +0300 Message-ID: <87pp42n7b4.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 803 Lines: 26 Chunyan Zhang writes: >> +int __init stp_configfs_init(void) >> +{ >> + int err; >> + >> + config_group_init(&stp_policy_subsys.su_group); >> + mutex_init(&stp_policy_subsys.su_mutex); >> + err = configfs_register_subsystem(&stp_policy_subsys); >> + >> + return err; > > One small suggestion, is it better like this: > return configfs_register_subsystem(&stp_policy_subsys); > As such, we don't need the local variable "err" any more. You are right, err doesn't serve any purpose here. Thanks, -- Alex -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/