Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934204AbbGHNJk (ORCPT ); Wed, 8 Jul 2015 09:09:40 -0400 Received: from mga02.intel.com ([134.134.136.20]:6439 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934133AbbGHNJi (ORCPT ); Wed, 8 Jul 2015 09:09:38 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,431,1432623600"; d="scan'208";a="725038434" From: Alexander Shishkin To: Peter Zijlstra , Chunyan Zhang Cc: rostedt@goodmis.org, mingo@redhat.com, mathieu.poirier@linaro.org, serge.broslavsky@linaro.org, broonie@kernel.org, zhang.lyra@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v3 1/4] STM trace event: Adding generic buffer interface driver In-Reply-To: <20150708121029.GE12596@twins.programming.kicks-ass.net> References: <20150708121029.GE12596@twins.programming.kicks-ass.net> User-Agent: Notmuch/0.20.1 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Wed, 08 Jul 2015 16:09:18 +0300 Message-ID: <87fv4yn6dd.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 865 Lines: 22 Peter Zijlstra writes: > On Tue, Jul 07, 2015 at 06:10:40PM +0800, Chunyan Zhang wrote: >> +config STM_TRACE_EVENT >> + tristate "Redirect/copy the output from kernel trace event to STM engine" > > How does tristate make sense here? You're using it unconditionally for > in-kernel tracepoints. This must be bool, which in turn makes the whole > STM thing bool afaiu. That would make the whole STM thing a bool. I'd rather we used stm output *conditionally* by somehow plugging into tracepoint output, say with a jump label or something. Haven't had time to think about it yet. Regards, -- Alex -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/