Date: Wed, 8 Jul 2015 15:22:08 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Chunyan Zhang <zhang.chunyan@linaro.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
        Steven Rostedt <rostedt@goodmis.org>, mingo@redhat.com,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        Serge Broslavsky <serge.broslavsky@linaro.org>, broonie@kernel.org,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Lyra Zhang <zhang.lyra@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v3 4/4] trace: Trace log handler for logging into STM
 blocks
Message-ID: <20150708132207.GA23380@gmail.com>
References: <cover.1436262902.git.zhang.chunyan@linaro.org>
 <a1bde0b882e36eb81579e9fb6d2561bdfaee4c06.1436262902.git.zhang.chunyan@linaro.org>
 <20150708123148.GF12596@twins.programming.kicks-ass.net>
 <CAG2=9p_quGLBe=fuSTqqjqS0NppO5E0KWMUSybkLFo5TO72nZg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAG2=9p_quGLBe=fuSTqqjqS0NppO5E0KWMUSybkLFo5TO72nZg@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1012
Lines: 25


* Chunyan Zhang <zhang.chunyan@linaro.org> wrote:

> >> +++ b/include/trace/perf.h
> >> @@ -175,6 +175,7 @@ trace_event_raw_event_##call(void *__data, proto)                 \
> >>       { assign; }                                                     \
> >>                                                                       \
> >>       trace_event_buffer_commit(&fbuffer);                            \
> >> +     trace_event_stm_log(&fbuffer);                                  \
> >
> > This makes every trace event slower.
> 
> It doesn't actually, you may decide if enable this feature, the trace event will 
> not be slowed if STM_TRACE_EVENT is not selected.

It slows down everyone if a distro enables this feature - that's not acceptable.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/