Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934990AbbGHN2c (ORCPT ); Wed, 8 Jul 2015 09:28:32 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:36099 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758247AbbGHN21 (ORCPT ); Wed, 8 Jul 2015 09:28:27 -0400 MIME-Version: 1.0 In-Reply-To: <559CFFBE.80801@suse.de> References: <20150707204916.6218.37871.stgit@bhelgaas-glaptop2.roam.corp.google.com> <20150707205233.6218.13548.stgit@bhelgaas-glaptop2.roam.corp.google.com> <559CFFBE.80801@suse.de> From: Bjorn Helgaas Date: Wed, 8 Jul 2015 08:28:06 -0500 Message-ID: Subject: Re: [PATCH v3 2/3] megaraid_sas : use dev_printk when possible To: Hannes Reinecke Cc: Kashyap Desai , Uday Lingala , Sumit Saxena , "PDL,MEGARAIDLINUX" , "linux-scsi@vger.kernel.org" , "James E.J. Bottomley" , "linux-kernel@vger.kernel.org" , Joe Perches , Christoph Hellwig Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1898 Lines: 42 On Wed, Jul 8, 2015 at 5:47 AM, Hannes Reinecke wrote: > On 07/07/2015 10:52 PM, Bjorn Helgaas wrote: >> Use dev_printk() when possible to make messages more useful. >> >> Signed-off-by: Bjorn Helgaas >> --- >> drivers/scsi/megaraid/megaraid_sas_base.c | 304 +++++++++++++-------------- >> drivers/scsi/megaraid/megaraid_sas_fusion.c | 95 ++++---- >> 2 files changed, 196 insertions(+), 203 deletions(-) >> > [ .. ] >> @@ -1873,8 +1872,8 @@ static int megasas_get_ld_vf_affiliation_111(struct megasas_instance *instance, >> cmd = megasas_get_cmd(instance); >> >> if (!cmd) { >> - printk(KERN_DEBUG "megasas: megasas_get_ld_vf_affiliation_111:" >> - "Failed to get cmd for scsi%d.\n", >> + dev_printk(KERN_DEBUG, &instance->pdev->dev, "megasas_get_ld_vf_affiliation_111:" >> + "Failed to get cmd for scsi%d\n", >> instance->host->host_no); >> return -ENOMEM; >> } > Makes one wonder why we don't have a 'dev_debug'; dev_notice() and > dev_warn() are there ... There actually is a 'dev_dbg()' but when CONFIG_DYNAMIC_DEBUG is set, I think dev_dbg() generates no output by default. So to preserve the previous behavior of "this message always appears in the dmesg log no matter what the dynamic debug setting," I used dev_printk(KERN_DEBUG). Somebody who maintains these drivers could probably go through and convert these to either dev_info() or dev_dbg() depending on what they need. That would require more judgment than I wanted to get into :) Thanks for taking a look at these! Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/