Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965075AbbGHOA7 (ORCPT ); Wed, 8 Jul 2015 10:00:59 -0400 Received: from www.linutronix.de ([62.245.132.108]:37648 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932599AbbGHOA5 (ORCPT ); Wed, 8 Jul 2015 10:00:57 -0400 Date: Wed, 8 Jul 2015 16:00:48 +0200 (CEST) From: Thomas Gleixner To: Arjan van de Ven cc: Andy Lutomirski , x86@kernel.org, LKML , Oleg Nesterov , Kees Cook , Peter Zijlstra , Borislav Petkov , Linus Torvalds Subject: Re: [PATCH] x86/kconfig/32: Mark CONFIG_VM86 as BROKEN In-Reply-To: <559C8BFE.6050604@linux.intel.com> Message-ID: References: <23d4709cee2fe92c32d41b99c7a3c1823725925a.1436312944.git.luto@kernel.org> <559C8BFE.6050604@linux.intel.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1286 Lines: 31 On Tue, 7 Jul 2015, Arjan van de Ven wrote: > On 7/7/2015 6:25 PM, Andy Lutomirski wrote: > > VM86 is entirely broken if ptrace, syscall auditing, or NOHZ_FULL is > > in use. The code is a big undocumented mess, it's a real PITA to > > test, and it looks like a big chunk of vm86_32.c is dead code. It > > also plays awful games with the entry asm. > > > > No one should be using it anyway. Use DOSBOX or KVM instead. > > > > Mark it BROKEN. I want to remove some (obviously incorrect) exit > > asm that it depends on, and I don't want to figure out how to run > > severely obsolete programs just to test something that no one uses > > for anything other than exploits anyway. > > > > while it is never great to deprecate features, in this case I am not sure > there is another choice unless someone steps up to seriously revamp this code. > (and look at it from a PREEMPT, NO_HZ etc etc angle) Aside of being broken in so many aspects it's even more obsolete than 386 support, we should just remove it right away. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/