Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932897AbbGHOl1 (ORCPT ); Wed, 8 Jul 2015 10:41:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38121 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932684AbbGHOlX (ORCPT ); Wed, 8 Jul 2015 10:41:23 -0400 Date: Wed, 8 Jul 2015 16:41:18 +0200 From: Jiri Olsa To: kan.liang@intel.com Cc: acme@kernel.org, jolsa@kernel.org, namhyung@kernel.org, ak@linux.intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC V2 1/5] perf,tools: introduce OPT_CALLBACK_SET/OPT_CALLBACK_NOOPT_SET Message-ID: <20150708144118.GA13619@krava.redhat.com> References: <1436264345-12085-1-git-send-email-kan.liang@intel.com> <1436264345-12085-2-git-send-email-kan.liang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436264345-12085-2-git-send-email-kan.liang@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2269 Lines: 50 On Tue, Jul 07, 2015 at 06:19:01AM -0400, kan.liang@intel.com wrote: > From: Kan Liang > > This patch extends the OPT_CALLBACK/OPT_CALLBACK_NOOPT to support 'set' > item of struct option. So the perf knows whether an option was set by > user. > The new macros are used by call-graph and timestamp options. > > Signed-off-by: Kan Liang > --- > tools/perf/builtin-record.c | 7 ++++--- > tools/perf/perf.h | 2 ++ > tools/perf/util/parse-options.c | 2 ++ > tools/perf/util/parse-options.h | 4 ++++ > 4 files changed, 12 insertions(+), 3 deletions(-) > > diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c > index de165a1..c270993 100644 > --- a/tools/perf/builtin-record.c > +++ b/tools/perf/builtin-record.c > @@ -1018,10 +1018,10 @@ struct option __record_options[] = { > record__parse_mmap_pages), > OPT_BOOLEAN(0, "group", &record.opts.group, > "put the counters into a counter group"), > - OPT_CALLBACK_NOOPT('g', NULL, &record.opts, > + OPT_CALLBACK_NOOPT_SET('g', NULL, &record.opts, &record.opts.callgraph_set, > NULL, "enables call-graph recording" , > &record_callchain_opt), > - OPT_CALLBACK(0, "call-graph", &record.opts, > + OPT_CALLBACK_SET(0, "call-graph", &record.opts, &record.opts.callgraph_set, > "mode[,dump_size]", record_callchain_help, > &record_parse_callchain_opt), > OPT_INCR('v', "verbose", &verbose, > @@ -1030,7 +1030,8 @@ struct option __record_options[] = { > OPT_BOOLEAN('s', "stat", &record.opts.inherit_stat, > "per thread counts"), > OPT_BOOLEAN('d', "data", &record.opts.sample_address, "Record the sample addresses"), > - OPT_BOOLEAN('T', "timestamp", &record.opts.sample_time, "Record the sample timestamps"), > + OPT_BOOLEAN_SET('T', "timestamp", &record.opts.sample_time, > + &record.opts.sample_time_set, "Sample timestamps"), this hunk got in as: 3abebc55d70b perf record: Let user have timestamps with per-thread recording jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/