Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935255AbbGHPnj (ORCPT ); Wed, 8 Jul 2015 11:43:39 -0400 Received: from mx2.parallels.com ([199.115.105.18]:51727 "EHLO mx2.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934770AbbGHPlV (ORCPT ); Wed, 8 Jul 2015 11:41:21 -0400 Date: Wed, 8 Jul 2015 18:41:12 +0300 From: Vladimir Davydov To: Michal Hocko CC: Johannes Weiner , Andrew Morton , Tejun Heo , Oleg Nesterov , Greg Thelen , KAMEZAWA Hiroyuki , KOSAKI Motohiro , , LKML Subject: Re: [PATCH 2/8] memcg: get rid of mem_cgroup_root_css for !CONFIG_MEMCG Message-ID: <20150708154111.GB2436@esperanza> References: <1436358472-29137-1-git-send-email-mhocko@kernel.org> <1436358472-29137-3-git-send-email-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1436358472-29137-3-git-send-email-mhocko@kernel.org> X-Originating-IP: [81.5.99.64] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 752 Lines: 16 On Wed, Jul 08, 2015 at 02:27:46PM +0200, Michal Hocko wrote: > The only user is cgwb_bdi_init and that one depends on > CONFIG_CGROUP_WRITEBACK which in turn depends on CONFIG_MEMCG > so it doesn't make much sense to definte an empty stub for > !CONFIG_MEMCG. Moreover ERR_PTR(-EINVAL) is ugly and would lead > to runtime crashes if used in unguarded code paths. Better fail > during compilation. > > Signed-off-by: Michal Hocko Reviewed-by: Vladimir Davydov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/