Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934824AbbGHQhf (ORCPT ); Wed, 8 Jul 2015 12:37:35 -0400 Received: from sbrk.org ([91.121.93.86]:56758 "EHLO sbrk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933872AbbGHQhb (ORCPT ); Wed, 8 Jul 2015 12:37:31 -0400 X-Greylist: delayed 400 seconds by postgrey-1.27 at vger.kernel.org; Wed, 08 Jul 2015 12:37:30 EDT Date: Wed, 8 Jul 2015 18:30:48 +0200 (CEST) From: Sebastien Rannou To: Stas Sergeev cc: netdev@vger.kernel.org, Linux kernel , Stas Sergeev , Thomas Petazzoni Subject: Re: [5/6] mvneta: implement SGMII-based in-band link state signaling In-Reply-To: <55155D9D.6070800@list.ru> Message-ID: References: <55155D9D.6070800@list.ru> User-Agent: Alpine 2.02 (LNX 1266 2009-07-14) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="2036029021-1673931612-1436373048=:28659" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1941 Lines: 56 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --2036029021-1673931612-1436373048=:28659 Content-Type: TEXT/PLAIN; charset=utf-8 Content-Transfer-Encoding: 8BIT Hi Stas, On Fri, 27 Mar 2015, Stas Sergeev wrote: > When MDIO bus is unavailable (common setup for SGMII), the in-band > signaling must be used to correctly track link state. > This patch enables the in-band status delivery and interrupts for > links state changes, namely: > - link up/down > - link speed > - duplex full/half > Upon reciving the appropriate interrupt, the driver updates the > fixed_phy status to match the received status. I'm seeing a regression with this patch when trying to netboot an Armada XP board (by reverting this commit it is fine), the network link stays down: [ 9.274492] mvneta d0070000.ethernet eth0: Link is Down (I've added an extra call to phy_print_status() in mvneta_adjust_link() to get this trace). I've tried to dig a bit in the code, and it seems that the status.link flag never gets set in mvneta_fixed_link_update(). If I try to force the use_inband_status to 0 in mvneta_probe(), it boots properly so I'm not sure that I need the in-band status/delivery in my case ; I'm using a custom DTB with a fixed-link: eth0: ethernet@70000 { status = "okay"; fixed-link = <1 1 1000 0 0>; phy-mode = "sgmii"; }; Could there be something missing in the condition that initializes pp->use_inband_status? PS: I've also tried to apply this patch without success: https://lkml.org/lkml/2015/6/18/496 -- Sébastien --2036029021-1673931612-1436373048=:28659-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/