Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S965143AbbGHQey (ORCPT <rfc822;w@1wt.eu>);
	Wed, 8 Jul 2015 12:34:54 -0400
Received: from cantor2.suse.de ([195.135.220.15]:41517 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S934595AbbGHQek (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 8 Jul 2015 12:34:40 -0400
Subject: Re: config PROC_CHILDREN
From: Jean Delvare <jdelvare@suse.de>
To: Iago =?ISO-8859-1?Q?L=F3pez?= Galeiras <iago@endocode.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Djalal Harouni <djalal@endocode.com>,
        Alban Crequy <alban@endocode.com>,
        Cyrill Gorcunov <gorcunov@openvz.org>,
        Andrew Morton <akpm@linux-foundation.org>
In-Reply-To: <559D3134.1080603@endocode.com>
References: <20150703093918.75b98eb7@endymion.delvare>
	 <55965195.6010602@endocode.com> <20150704190728.6a1b8a5a@endymion.delvare>
	 <559D3134.1080603@endocode.com>
Content-Type: text/plain; charset="UTF-8"
Organization: Suse Linux
Date: Wed, 08 Jul 2015 18:34:38 +0200
Message-ID: <1436373278.4618.5.camel@chaos.site>
Mime-Version: 1.0
X-Mailer: Evolution 2.28.2 
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1631
Lines: 38

Le Wednesday 08 July 2015 à 16:18 +0200, Iago López Galeiras a écrit :
> On 07/04/2015 07:07 PM, Jean Delvare wrote:
> > On Fri, 3 Jul 2015 11:10:45 +0200, Iago López Galeiras wrote:
> >> The purpose of this option is enabling /proc/<pid>/task/<tid>/children without
> >> having to enable CHECKPOINT_RESTORE, which is hidden behind EXPERT.
> >>
> >> Regarding its lack of help, documentation is in already in place[1] but perhaps
> >> that's not clear for the user because as you say the Kconfig help text is missing.
> >>
> >> I suggest adding something like:
> >>
> >>     Provides a fast way to retrieve first level children pids of a task. See
> >>     <file:Documentation/filesystems/proc.txt> for more information.
> >>
> >> Do you think that's enough?
> > 
> > That's a start, the reference to Documentation/filesystems/proc.txt is
> > good but I think we can do better. You need to help the user make the
> > decision. Why should he/she say Y or N? The user should NOT have to look
> > at an external documentation file if the answer is N. I would suggest
> > the following:
> > 
> > Say Y if running any user-space software which takes benefit from this
> > interface. For example, rkt is such a piece of software.
> 
> That makes it more clear for the user. Thanks!

You're welcome. Will you submit a patch, or should I take care of it?

-- 
Jean Delvare
SUSE L3 Support

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/