Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934881AbbGHQm4 (ORCPT ); Wed, 8 Jul 2015 12:42:56 -0400 Received: from mail-pd0-f182.google.com ([209.85.192.182]:33201 "EHLO mail-pd0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933960AbbGHQmy convert rfc822-to-8bit (ORCPT ); Wed, 8 Jul 2015 12:42:54 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: Morten Rasmussen , peterz@infradead.org, mingo@redhat.com From: Michael Turquette In-Reply-To: <1436293469-25707-46-git-send-email-morten.rasmussen@arm.com> Cc: vincent.guittot@linaro.org, daniel.lezcano@linaro.org, "Dietmar Eggemann" , yuyang.du@intel.com, rjw@rjwysocki.net, "Juri Lelli" , sgurrappadi@nvidia.com, pang.xunlei@zte.com.cn, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, "Juri Lelli" References: <1436293469-25707-1-git-send-email-morten.rasmussen@arm.com> <1436293469-25707-46-git-send-email-morten.rasmussen@arm.com> Message-ID: <20150708164235.9112.55369@quantum> User-Agent: alot/0.3.5 Subject: Re: [RFCv5 PATCH 45/46] sched/cpufreq_sched: modify pcpu_capacity handling Date: Wed, 08 Jul 2015 09:42:35 -0700 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1628 Lines: 47 Quoting Morten Rasmussen (2015-07-07 11:24:28) > From: Juri Lelli > > Use the cpu argument of cpufreq_sched_set_cap() to handle per_cpu writes, > as the thing can be called remotely (e.g., from load balacing code). > > cc: Ingo Molnar > cc: Peter Zijlstra > > Signed-off-by: Juri Lelli Looks good to me. Feel free to add my Reviewed-by or Acked-by as appropriate. Regards, Mike > --- > kernel/sched/cpufreq_sched.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/sched/cpufreq_sched.c b/kernel/sched/cpufreq_sched.c > index 06ff183..b81ac779 100644 > --- a/kernel/sched/cpufreq_sched.c > +++ b/kernel/sched/cpufreq_sched.c > @@ -151,7 +151,7 @@ void cpufreq_sched_set_cap(int cpu, unsigned long capacity) > unsigned long capacity_max = 0; > > /* update per-cpu capacity request */ > - __this_cpu_write(pcpu_capacity, capacity); > + per_cpu(pcpu_capacity, cpu) = capacity; > > policy = cpufreq_cpu_get(cpu); > if (IS_ERR_OR_NULL(policy)) { > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/