Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758925AbbGHQx7 (ORCPT ); Wed, 8 Jul 2015 12:53:59 -0400 Received: from svenfoo.org ([82.94.215.22]:50174 "EHLO mail.zonque.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932348AbbGHQx4 (ORCPT ); Wed, 8 Jul 2015 12:53:56 -0400 X-Greylist: delayed 596 seconds by postgrey-1.27 at vger.kernel.org; Wed, 08 Jul 2015 12:53:56 EDT Subject: Re: [RFC 2/8] lsm: smack: Make ipc/kdbus includes visible so smack callbacks could see them To: Paul Osmialowski , Paul Moore , James Morris , Casey Schaufler , "Serge E. Hallyn" , Kees Cook , Tetsuo Handa , Stephen Smalley , Neil Brown , Mark Rustad , Greg Kroah-Hartman , David Herrmann , Djalal Harouni , Shuah Khan , Al Viro , linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org References: <1436351110-5902-1-git-send-email-p.osmialowsk@samsung.com> <1436351110-5902-3-git-send-email-p.osmialowsk@samsung.com> Cc: Karol Lewandowski , Lukasz Skalski From: Daniel Mack X-Enigmail-Draft-Status: N1110 Message-ID: <559D5349.50409@zonque.org> Date: Wed, 8 Jul 2015 12:43:53 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <1436351110-5902-3-git-send-email-p.osmialowsk@samsung.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1183 Lines: 35 On 07/08/2015 06:25 AM, Paul Osmialowski wrote: > Signed-off-by: Paul Osmialowski > --- > security/smack/Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/security/smack/Makefile b/security/smack/Makefile > index ee2ebd5..bd6927c 100644 > --- a/security/smack/Makefile > +++ b/security/smack/Makefile > @@ -6,3 +6,5 @@ obj-$(CONFIG_SECURITY_SMACK) := smack.o > > smack-y := smack_lsm.o smack_access.o smackfs.o > smack-$(CONFIG_SECURITY_SMACK_NETFILTER) += smack_netfilter.o > + > +ccflags-y += -Iipc > I would really like to avoid exposing the internal structures of kdbus to LSM modules. This is going to get messy if any internals change in the future. The callbacks for smack currently only use the passed structure to access the opaque 'security' pointer. Can't you just pass that directly (as void**), along with other parameters the LSMs needs to know about? Thanks, Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/