Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758842AbbGHQ7Y (ORCPT ); Wed, 8 Jul 2015 12:59:24 -0400 Received: from mail-ig0-f178.google.com ([209.85.213.178]:35880 "EHLO mail-ig0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754594AbbGHQ7U (ORCPT ); Wed, 8 Jul 2015 12:59:20 -0400 MIME-Version: 1.0 In-Reply-To: <559C8BFE.6050604@linux.intel.com> References: <23d4709cee2fe92c32d41b99c7a3c1823725925a.1436312944.git.luto@kernel.org> <559C8BFE.6050604@linux.intel.com> Date: Wed, 8 Jul 2015 09:59:19 -0700 X-Google-Sender-Auth: tbkeOG4PVq4cwoUO2wHHX9p2RlM Message-ID: Subject: Re: [PATCH] x86/kconfig/32: Mark CONFIG_VM86 as BROKEN From: Linus Torvalds To: Arjan van de Ven Cc: Andy Lutomirski , "the arch/x86 maintainers" , Linux Kernel Mailing List , Oleg Nesterov , Kees Cook , Peter Zijlstra , Borislav Petkov Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1120 Lines: 25 On Tue, Jul 7, 2015 at 7:33 PM, Arjan van de Ven wrote: > > if this patch would not be acceptable, at minimum we need some sort of "off > by default > unless the sysadmin flips a sysfs thing", which is really just a huge hack. The only thing that matters is whether people use this or not. If people use vm86 mode, we can't just disable it. It's that simple. "It's poorly maintained" isn't an argument for removal. Only "nobody cares" works as an argument for that. My suspicion is that people still do use vm86 mode, but who knows.. Quite frankly, rather than disable it, I'd much rather see people who modify low-level x86 code (yes, that means you, Luto) *test* it. If you aren't willign to test the modifications you make, I don't think those modifications should be merged, regardless of how nice a cleanup they are. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/