Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759107AbbGHR3r (ORCPT ); Wed, 8 Jul 2015 13:29:47 -0400 Received: from mail-ig0-f180.google.com ([209.85.213.180]:36485 "EHLO mail-ig0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758264AbbGHR3q (ORCPT ); Wed, 8 Jul 2015 13:29:46 -0400 MIME-Version: 1.0 In-Reply-To: References: Date: Wed, 8 Jul 2015 10:29:45 -0700 X-Google-Sender-Auth: _9Zp3V112hiqmt5_DYuc4XQV4qU Message-ID: Subject: Re: Linux 4.2-rc1 From: Linus Torvalds To: Shuah Khan , Ming Lei , Greg Kroah-Hartman Cc: Linux Kernel Mailing List , Shuah Khan Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1155 Lines: 37 On Wed, Jul 8, 2015 at 10:17 AM, Linus Torvalds wrote: > > Decoding the "Code:" line shows that this is the "->fw_id" dereference in > > if (add_uevent_var(env, "FIRMWARE=%s", fw_priv->buf->fw_id)) > return -ENOMEM; > > and that "fw_priv->buf" pointer is NULL. > > However, I don't see anything that looks like it should have changed > any of this since 4.1. Looking at the otehr uses of "fw_priv->buf", they all check that pointer for NULL. I see code like fw_buf = fw_priv->buf; if (!fw_buf) goto out; etc. Also, it looks like you need to hold the "fw_lock" to even look at that pointer, since the buffer can get reallocated etc. So that uevent code really looks buggy. It just doesn't look like a *new* bug to me. That code looks old, going back to 2012 and commit 1244691c73b2. Ming Lei? Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/