Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759487AbbGHSEN (ORCPT ); Wed, 8 Jul 2015 14:04:13 -0400 Received: from emvm-gh1-uea08.nsa.gov ([63.239.67.9]:57912 "EHLO emvm-gh1-uea08.nsa.gov" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758642AbbGHSEM (ORCPT ); Wed, 8 Jul 2015 14:04:12 -0400 X-TM-IMSS-Message-ID: <803a60d6000fb929@nsa.gov> Message-ID: <559D65D8.9010003@tycho.nsa.gov> Date: Wed, 08 Jul 2015 14:03:04 -0400 From: Stephen Smalley Organization: National Security Agency User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Casey Schaufler , Linus Torvalds , Shuah Khan , Ming Lei , Greg Kroah-Hartman , SE Linux , william.c.roberts@intel.com CC: Linux Kernel Mailing List , Shuah Khan Subject: Re: Linux 4.2-rc1 References: <559D623D.405@schaufler-ca.com> In-Reply-To: <559D623D.405@schaufler-ca.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1472 Lines: 42 On 07/08/2015 01:47 PM, Casey Schaufler wrote: > On 7/8/2015 10:29 AM, Linus Torvalds wrote: >> On Wed, Jul 8, 2015 at 10:17 AM, Linus Torvalds >> wrote: >>> Decoding the "Code:" line shows that this is the "->fw_id" dereference in >>> >>> if (add_uevent_var(env, "FIRMWARE=%s", fw_priv->buf->fw_id)) >>> return -ENOMEM; >>> >>> and that "fw_priv->buf" pointer is NULL. >>> >>> However, I don't see anything that looks like it should have changed >>> any of this since 4.1. >> Looking at the otehr uses of "fw_priv->buf", they all check that >> pointer for NULL. I see code like >> >> fw_buf = fw_priv->buf; >> if (!fw_buf) >> goto out; >> >> etc. >> >> Also, it looks like you need to hold the "fw_lock" to even look at >> that pointer, since the buffer can get reallocated etc. >> >> So that uevent code really looks buggy. It just doesn't look like a >> *new* bug to me. That code looks old, going back to 2012 and commit >> 1244691c73b2. > > There have been SELinux changes to kernfs for 4.2. William, > you might want to have a look here. What change are you referring to? I see no SELinux-related changes to kernfs in 4.2-rc1. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/