MIME-Version: 1.0
In-Reply-To: <1436379071-31574-1-git-send-email-albeu@free.fr>
References: <1436379071-31574-1-git-send-email-albeu@free.fr>
From: Jonas Gorski <jogo@openwrt.org>
Date: Wed, 8 Jul 2015 20:28:05 +0200
Message-ID: <CAOiHx=kDKETVHDeNKM-_7nUZJmWHyPSyUSWfwLtsJA2HG+hV1A@mail.gmail.com>
Subject: Re: [PATCH] MIPS: ath79: irq: Remove the include of drivers/irqchip/irqchip.h
To: Alban Bedel <albeu@free.fr>
Cc: MIPS Mailing List <linux-mips@linux-mips.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ralf Baechle <ralf@linux-mips.org>,
        Andrew Bresticker <abrestic@chromium.org>,
        Qais Yousef <qais.yousef@imgtec.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1359
Lines: 41

On Wed, Jul 8, 2015 at 8:11 PM, Alban Bedel <albeu@free.fr> wrote:
> We shouldn't include irqchip.h from outside of the drivers/irqchip
> directory. The irq driver should idealy be there, however this not
> trivial at the moment. We still need to support platforms without DT
> support and the interface to the DDR controller still use a custom
> arch specific API.
>
> For now just redefine the IRQCHIP_DECLARE macro to avoid the cross
> tree include.
>
> Signed-off-by: Alban Bedel <albeu@free.fr>

The define was moved into linux/irqchip.h in
91e20b5040c67c51aad88cf87db4305c5bd7f79d, so all you can/need to do is
...
> ---
>  arch/mips/ath79/irq.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/arch/mips/ath79/irq.c b/arch/mips/ath79/irq.c
> index afb0096..c5ad737 100644
> --- a/arch/mips/ath79/irq.c
> +++ b/arch/mips/ath79/irq.c
> @@ -17,7 +17,6 @@
>  #include <linux/interrupt.h>
>  #include <linux/irqchip.h>
>  #include <linux/of_irq.h>
> -#include "../../../drivers/irqchip/irqchip.h"
>
>  #include <asm/irq_cpu.h>
>  #include <asm/mipsregs.h>

this removal ;)


Jonas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/