Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758887AbbGHTZS (ORCPT ); Wed, 8 Jul 2015 15:25:18 -0400 Received: from mail.kernel.org ([198.145.29.136]:48069 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755535AbbGHTYS (ORCPT ); Wed, 8 Jul 2015 15:24:18 -0400 From: Andy Lutomirski To: x86@kernel.org, linux-kernel@vger.kernel.org Cc: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Weisbecker?= , Rik van Riel , Oleg Nesterov , Denys Vlasenko , Borislav Petkov , Kees Cook , Brian Gerst , Linus Torvalds , Andy Lutomirski Subject: [RFC/PATCH 3/7] [TEMPORARY] x86/entry/32: Sanity check for work_notifysig Date: Wed, 8 Jul 2015 12:24:00 -0700 Message-Id: X-Mailer: git-send-email 2.4.3 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1009 Lines: 35 44fbbb3dc687c added an unnecessary check. Add a temporary assertion to confirm that it's unnecessary. Signed-off-by: Andy Lutomirski --- arch/x86/entry/entry_32.S | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/x86/entry/entry_32.S b/arch/x86/entry/entry_32.S index a36d5df6a749..d36afad80ad1 100644 --- a/arch/x86/entry/entry_32.S +++ b/arch/x86/entry/entry_32.S @@ -491,10 +491,13 @@ work_notifysig: # deal with pending signals and #endif TRACE_IRQS_ON ENABLE_INTERRUPTS(CLBR_NONE) + /* Temporary sanity check */ movb PT_CS(%esp), %bl andb $SEGMENT_RPL_MASK, %bl cmpb $USER_RPL, %bl - jb resume_kernel + jnb 2f + ud2 +2: xorl %edx, %edx call do_notify_resume jmp resume_userspace -- 2.4.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/