Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758304AbbGHUPT (ORCPT ); Wed, 8 Jul 2015 16:15:19 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:36524 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755638AbbGHUPM (ORCPT ); Wed, 8 Jul 2015 16:15:12 -0400 Date: Wed, 8 Jul 2015 22:08:52 +0200 From: Andrew Lunn To: Vivien Didelot Cc: netdev , David , Scott Feldman , Jiri Pirko , Florian Fainelli , Guenter Roeck , linux-kernel , kernel Subject: Re: [PATCH v4 0/3] net: dsa: mv88e6xxx: add support for VLAN Table Unit Message-ID: <20150708200852.GD1357@lunn.ch> References: <1436303900-24259-1-git-send-email-vivien.didelot@savoirfairelinux.com> <20150708143805.GA32208@lunn.ch> <894793886.88178.1436375596747.JavaMail.zimbra@savoirfairelinux.com> <20150708173216.GB1357@lunn.ch> <1831874541.91682.1436379099609.JavaMail.zimbra@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1831874541.91682.1436379099609.JavaMail.zimbra@savoirfairelinux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 939 Lines: 20 > > This is a limitation of the switch. So the driver needs to keep track > > of which bridge a VLAN belongs to, if it is asked to accelerate the > > same VLAN for a different bridge, it needs to say to the kernel, > > sorry, cannot do that, and leave the kernel to do it in software. > > Scott, how do you think this must be done? Returning a different error > code when trying to add a SWITCHDEV_OBJ_PORT_VLAN object? > Not sure how to query this fallback. Is -EOPNOTSUPP enough? There was quite a bit of discussion about this a while back. It should return an error during the prepare phase. Looking at __vlan_vid_add() and switchdev_fib_ipv4_add, it should return EOPNOTSUPP. Andrew -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/