Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752585AbbGHXGp (ORCPT ); Wed, 8 Jul 2015 19:06:45 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:38256 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751209AbbGHXGg (ORCPT ); Wed, 8 Jul 2015 19:06:36 -0400 Date: Wed, 08 Jul 2015 16:06:34 -0700 (PDT) Message-Id: <20150708.160634.2087986100168064781.davem@davemloft.net> To: ranamazharp@gmail.com Cc: j.vosburgh@gmail.com, vfalico@gmail.com, gospo@cumulusnetworks.com, mazhar.rana@cyberoam.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, sanket.shah@cyberoam.com Subject: Re: [PATCH v3] bonding: "primary_reselect" with "failure" is not working properly From: David Miller In-Reply-To: <1436261690-1121-1-git-send-email-ranamazharp@gmail.com> References: <1436261690-1121-1-git-send-email-ranamazharp@gmail.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 08 Jul 2015 16:06:35 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1043 Lines: 24 From: Mazhar Rana Date: Tue, 7 Jul 2015 15:04:50 +0530 > From: Mazhar Rana > > When "primary_reselect" is set to "failure", primary interface should > not become active until current active slave is down. But if we set first > member of bond device as a "primary" interface and "primary_reselect" > is set to "failure" then whenever primary interface's link get back(up) > it become active slave even if current active slave is still up. > > With this patch, "bond_find_best_slave" will not traverse members if > primary interface is not candidate for failover/reselection and current > active slave is still up. > > Signed-off-by: Mazhar Rana > Signed-off-by: Jay Vosburgh Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/