Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751895AbbGHXZC (ORCPT ); Wed, 8 Jul 2015 19:25:02 -0400 Received: from mail-wg0-f52.google.com ([74.125.82.52]:34582 "EHLO mail-wg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751007AbbGHXYy (ORCPT ); Wed, 8 Jul 2015 19:24:54 -0400 MIME-Version: 1.0 In-Reply-To: <20150708231152.GA379@dtor-ws> References: <7389F224-E5E4-4DA0-A70F-4CBB70F53F2E@emc.com.tw> <20150707180624.GD12491@dtor-ws> <20150708231152.GA379@dtor-ws> Date: Wed, 8 Jul 2015 19:24:53 -0400 Message-ID: Subject: Re: [PATCH] Input: elan_i2c - Change the hover event from MT to ST From: Benjamin Tissoires To: Dmitry Torokhov Cc: duson , linux-input , "linux-kernel@vger.kernel.org" , Peter Hutterer Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1602 Lines: 38 On Wed, Jul 8, 2015 at 7:11 PM, Dmitry Torokhov wrote: > On Wed, Jul 08, 2015 at 06:58:36PM -0400, Benjamin Tissoires wrote: >> On Tue, Jul 7, 2015 at 2:06 PM, Dmitry Torokhov >> wrote: >> > On Tue, Jul 07, 2015 at 01:37:14PM +0800, duson wrote: >> >> We want the hover event like BTN_LEFT, even no contract object, >> >> it still can be reported to upper OS system. >> >> >> >> Signed-off by: Duson Lin >> > >> > Applied, thank you. >> >> Sorry for waking up too late but I am not sure we want this patch. >> >> Why do we need to remove the ABS_MT_DISTANCE bits? I can understand >> that we would want to to have ABS_DISTANCE for the pointer emulation, >> but removing the per-finger information does not make much sense. >> libinput knows now how to deal with per-finger hovering through >> ABS_MT_DISTANCE, and you are just breaking the touchpad/screens with >> this patch. > > Because the device does not provide per-finger information about > hovering. It can only tell that there is "something" hovering over the > surface, but it doe snot provide the data that there are 2 fingers > hovering or that finger 1 was in contact but now is hovering, etc. > OK, I see now. I have then no opinion on the patch itself (not sure any client uses ABS_DISTANCE) :) Cheers, Benjamin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/