Message-ID: <559DBE28.4000907@codeweavers.com>
Date: Wed, 08 Jul 2015 19:19:52 -0500
From: Jeremy White <jwhite@codeweavers.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0
MIME-Version: 1.0
To: Hans de Goede <hdegoede@redhat.com>, Greg KH <greg@kroah.com>
CC: spice-devel@lists.freedesktop.org, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/1] Add a usbredir kernel module to remotely connect
 USB devices over IP.
References: <1435700650-640-1-git-send-email-jwhite@codeweavers.com> <1435700650-640-2-git-send-email-jwhite@codeweavers.com> <20150630234805.GB13573@kroah.com> <55935FC1.8090203@codeweavers.com> <20150701054416.GA23370@kroah.com> <55940D85.9030702@codeweavers.com> <20150701161342.GB31389@kroah.com> <559C0285.6090509@codeweavers.com> <559CCD39.90606@redhat.com>
In-Reply-To: <559CCD39.90606@redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1707
Lines: 41

On 07/08/2015 02:11 AM, Hans de Goede wrote:
> Hi,
>
> On 07-07-15 18:47, Jeremy White wrote:
>>
>>>>
>>>> Well, the checkpatch.pl reports were all style (and mostly whitespace);
>>>> roughly 3000 of them against 3000 lines of code :-/.  I did review the
>>>> code, looking for areas where I thought it would badly cram into the
>>>> kernel, and I adjusted the few I found (and sent changes upstream).
>>>
>>> style matters, as it's a thing with your brain.  You learn patterns and
>>> if the patterns change, you have to do more work and don't see the real
>>> issues involved.  So by ignoring our style you are saying you don't want
>>> anyone else in the kernel community to ever review or work on the code,
>>> which isn't ok.
>>
>> Looks like I can't side step this unless Hans is willing to shift the
>> usbredir project entirely to using kernel style :-/.
>
> I'm fine with moving the usbredir project to the kernel style, the question
> is how to do this without causing any hidden breakage.
>
> Can you create a gnu-indent invocation which will do most of the work?
>
> And then a hopefully managable sized patch on top to fix the remaining
> style errors in usbredirparser ?

Got it; that's a helpful surprise.  I'll work on patches for all but the 
whitespace, for only the files needed.  I'm hoping whitespace changes 
can be limited to a gnu-indent invocation at patch transfer time. I'd 
hate to destroy the history like that :-/.

Cheers,

Jeremy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/