Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753230AbbGIB1G (ORCPT ); Wed, 8 Jul 2015 21:27:06 -0400 Received: from col004-omc3s16.hotmail.com ([65.55.34.154]:58775 "EHLO COL004-OMC3S16.hotmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753091AbbGIB06 (ORCPT ); Wed, 8 Jul 2015 21:26:58 -0400 X-TMN: [jnj0FmWBSymy0W1cvrnIb9bEUsh4jb7U] X-Originating-Email: [xili_gchen_5257@hotmail.com] Message-ID: From: gchen gchen To: "Valdis.Kletnieks@vt.edu" CC: "starvik@axis.com" , "jesper.nilsson@axis.com" , "linux-cris-kernel@axis.com" , kernel mailing list , Hans-Peter Nilsson Subject: Re: [PATCH] cris: arch-v10: kernel: kgdb: let is_dyn_brkp as extern variable Date: Thu, 9 Jul 2015 09:26:57 +0800 Importance: Normal In-Reply-To: <559DCD4B.2080600@hotmail.com> References: <258005.1436120701@turing-police.cc.vt.edu> <20238.1436178687@turing-police.cc.vt.edu> ,<559DCD4B.2080600@hotmail.com> Content-Type: text/plain; charset="gb2312" MIME-Version: 1.0 X-OriginalArrivalTime: 09 Jul 2015 01:26:57.0771 (UTC) FILETIME=[58D4EBB0:01D0B9E6] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t691RANm029799 Content-Length: 1892 Lines: 53 On 07/07/2015 06:28 AM, Chen Gang wrote: > On 7/6/15 18:31, Valdis.Kletnieks@vt.edu wrote: >> On Mon, 06 Jul 2015 15:49:20 +0800, Chen Gang said: >>> On 07/06/2015 02:25 AM, Valdis.Kletnieks@vt.edu wrote: >>>> On Sun, 05 Jul 2015 06:07:54 +0800, Chen Gang said: >>>>> For upstream cris toolchain (gcc is 6.0 >>>> >>>> typo? >>>> >>> >>> Do you mean "toolchain" -> "tool chain"? >> >> No, I was wondering where a gcc 6.0 managed to escape when 5.1 just got >> released about 2 weeks ago.... >> > Oh, sorry, gcc 5.1 is the same, and at present, for me: - The new gcc have additional optimization for the static variables. It should notice about the related c code when optimizing, but gcc has no idea about assembly code (it should passes them to gas, directly). - If one want gcc skip the related optimization, it can use 'volatile' for it (the static variable which may be used by both c code and assembly code in one file). - So I guess, we need add 'volatile' to the related static variable, we do not want to disable this optimization only because of this issue. Welcome any additional ideas, suggestions and completions. > OK, thanks. At present, gcc 6.0 is the latest in master branch. > > After check fedora released toolchain (gcc 4.9.1, binutils 2.25), it has > no issue (support static variable in our case). So this patch can be > dropped, and I shall try: > > - Use the same configuration parameters of fedora released toolchain to > build the upstream latest cross toolchain again, and try. > > - If it still has issue (not support static variable), I shall try to > fix it. > > > Thanks. > -- Chen Gang Open, share, and attitude like air, water, and life which God blessed ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?