Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753926AbbGIB5X (ORCPT ); Wed, 8 Jul 2015 21:57:23 -0400 Received: from mail.kernel.org ([198.145.29.136]:38327 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753559AbbGIB4G (ORCPT ); Wed, 8 Jul 2015 21:56:06 -0400 Date: Thu, 9 Jul 2015 09:55:51 +0800 From: Shawn Guo To: Bill Pringlemeir Cc: Stefan Agner , dwmw2@infradead.org, computersforpeace@gmail.com, sebastian@breakpoint.cc, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, shawn.guo@linaro.org, kernel@pengutronix.de, boris.brezillon@free-electrons.com, marb@ixxat.de, aaron@tastycactus.com, bpringlemeir@gmail.com, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 4/6] ARM: vf610: enable NAND Flash Controller Message-ID: <20150709015551.GJ28488@tiger> References: <1434668319-6651-1-git-send-email-stefan@agner.ch> <1434668319-6651-5-git-send-email-stefan@agner.ch> <20150708093801.GG28488@tiger> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1659 Lines: 42 On Wed, Jul 08, 2015 at 10:32:54AM -0400, Bill Pringlemeir wrote: > > On 8 Jul 2015, shawnguo@kernel.org wrote: > > On Fri, Jun 19, 2015 at 12:58:37AM +0200, Stefan Agner wrote: > >> Enable the NAND Flash Controller driver which is part of the Vybrid > >> SoC by default. > >> > >> Signed-off-by: Stefan Agner > >> --- > >> arch/arm/mach-imx/Kconfig | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig > >> index 3a3d3e9..9358135 100644 > >> --- a/arch/arm/mach-imx/Kconfig > >> +++ b/arch/arm/mach-imx/Kconfig > >>>> -589,6 +589,7 @@ config SOC_VF610 > >> select PINCTRL_VF610 > >> select PL310_ERRATA_769419 if CACHE_L2X0 > >> select SMP_ON_UP if SMP > >> + select HAVE_NAND_VF610_NFC > > > I'm not sure about the benefit of having this option, except we have > > to have this additional architecture patch. > > For other SOC, like the PowerPC or ColdFire CPUs with this controller, > it was a way to mark the controller as populated. Otherwise, the > Kconfig entry to select the controller will pop up for everybody. IMHO, having the option pop up for everybody isn't really a problem. On the other hand, we can even compile test the driver on any architecture without the COMPILE_TEST dependency. But if MTD maintainer has a different opinion, we can still have a 'depends on SOC_VF610' to save this patch. Shawn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/