Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752386AbbGIFrs (ORCPT ); Thu, 9 Jul 2015 01:47:48 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:40057 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751639AbbGIFrl (ORCPT ); Thu, 9 Jul 2015 01:47:41 -0400 X-Listener-Flag: 11101 Message-ID: <1436420856.16651.11.camel@mtkswgap22> Subject: Re: [PATCH 2/2] arm64: dts: mediatek: add mt6795 support From: Mars Cheng To: Mark Rutland CC: Matthias Brugger , CC Hwang , Loda Chou , Miles Chen , Scott Shu , Jades Shih , Yingjoe Chen , "MY Chuang" , "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "devicetree@vger.kernel.org" Date: Thu, 9 Jul 2015 13:47:36 +0800 In-Reply-To: <20150708102343.GC7025@leverpostej> References: <1436350480-17276-1-git-send-email-mars.cheng@mediatek.com> <1436350480-17276-3-git-send-email-mars.cheng@mediatek.com> <20150708102343.GC7025@leverpostej> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4311 Lines: 158 > > + chosen { > > + bootargs = "console=ttyS0,921600n8 earlyprintk"; > > PLease get rid of bootargs here; earlyprintk doesn't do anything on > arm64 (it's earlycon these days), and you can specify the serial > configuration in stdout-path, so please use that instead. > Got it. Will remove bootargs & use stdout-path only. > > + stdout-path = &uart0; > > + }; > > +}; > > + > > +&uart0 { > > + status = "okay"; > > +}; > > diff --git a/arch/arm64/boot/dts/mediatek/mt6795.dtsi b/arch/arm64/boot/dts/mediatek/mt6795.dtsi > > new file mode 100644 > > index 0000000..832be20 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/mediatek/mt6795.dtsi > > @@ -0,0 +1,164 @@ > > +/* > > + * Copyright (c) 2015 MediaTek Inc. > > + * Author: Mars.C > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License version 2 as > > + * published by the Free Software Foundation. > > + * > > + * This program is distributed in the hope that it will be useful, > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + */ > > + > > +#include > > +#include > > + > > +/ { > > + compatible = "mediatek,mt6795"; > > + interrupt-parent = <&sysirq>; > > + #address-cells = <2>; > > + #size-cells = <2>; > > + > > + cpus { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + cpu0: cpu@0 { > > + device_type = "cpu"; > > + compatible = "arm,cortex-a53"; > > + reg = <0x000>; > > + }; > > + > > + cpu1: cpu@1 { > > + device_type = "cpu"; > > + compatible = "arm,cortex-a53"; > > + reg = <0x001>; > > + }; > > No enable-method? Does your FW patch that in? This patch only provides single core to boot.The proper enable-method for SMP boot is under discussion in our site. Will complete enable-method when providing our solution to SMP boot in the other patch set. > > > + > > + cpu2: cpu@2 { > > + device_type = "cpu"; > > + compatible = "arm,cortex-a53"; > > + reg = <0x002>; > > + }; > > + > > + cpu3: cpu@3 { > > + device_type = "cpu"; > > + compatible = "arm,cortex-a53"; > > + reg = <0x003>; > > + }; > > + > > + cpu4: cpu@4 { > > + device_type = "cpu"; > > + compatible = "arm,cortex-a53"; > > + reg = <0x100>; > > + }; > > The unit-address should match the reg (e.g. this should be cpu@100). Got it. Will fix this. > > > + > > + cpu5: cpu@5 { > > + device_type = "cpu"; > > + compatible = "arm,cortex-a53"; > > + reg = <0x101>; > > + }; > > + > > + cpu6: cpu@6 { > > + device_type = "cpu"; > > + compatible = "arm,cortex-a53"; > > + reg = <0x102>; > > + }; > > + > > + cpu7: cpu@7 { > > + device_type = "cpu"; > > + compatible = "arm,cortex-a53"; > > + reg = <0x103>; > > + }; > > + }; > > + > > + clocks { > > + system_clk: dummy13m { > > + compatible = "fixed-clock"; > > + clock-frequency = <13000000>; > > + #clock-cells = <0>; > > + }; > > + > > + rtc_clk: dummy32k { > > + compatible = "fixed-clock"; > > + clock-frequency = <32000>; > > + #clock-cells = <0>; > > + }; > > + > > + uart_clk: dummy26m { > > + compatible = "fixed-clock"; > > + clock-frequency = <26000000>; > > + #clock-cells = <0>; > > + }; > > + }; > > Get rid of the clocks node and place these directly under the root node. Got it. Will fix it. > > > + > > + timer { > > + compatible = "arm,armv8-timer"; > > + interrupt-parent = <&gic>; > > + interrupts = > + (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, > > + > + (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, > > + > + (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, > > + > + (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>; > > + }; > > The mask is wrong. They should be GIC_CPU_MASK_SIMPLE(8). Will fix these. Thanks for your suggestions. > > Thanks, > Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/