Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751809AbbGIG0W (ORCPT ); Thu, 9 Jul 2015 02:26:22 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:22850 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751085AbbGIG0S (ORCPT ); Thu, 9 Jul 2015 02:26:18 -0400 X-AuditID: cbfec7f5-f794b6d000001495-1d-559e14072ea7 From: Andrzej Hajda To: inki.dae@samsung.com Cc: Andrzej Hajda , Marek Szyprowski , Kyungmin Park , b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH RESEND 1/6] drm/exynos/hdmi: fix edid memory leak Date: Thu, 09 Jul 2015 08:25:38 +0200 Message-id: <1436423143-22027-2-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1436423143-22027-1-git-send-email-a.hajda@samsung.com> References: <1436423143-22027-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupkluLIzCtJLcpLzFFi42I5/e/4VV12kXmhBhM36FrcWneO1WLjjPWs Fle+vmezmHR/AovF2aY37BaXd81hs1h75C67A7vH/e7jTB59W1YxenzeJBfAHMVlk5Kak1mW WqRvl8CV8f5bC0vBDI6Kyz8/sDcwfmHrYuTkkBAwkZi1bwILhC0mceHeeqA4F4eQwFJGiW0b v4IVCQk0MUncOc8HYrMJaEr83XwTLC4iICEx89VFJhCbWeAeo8TpFxogtrCAo0Tz3bWsIDaL gKrE5TUfmEFsXgFniYUNF5gglslJnDw2GayGU8BF4vafHkaIXc4SZ1bsYJ7AyLuAkWEVo2hq aXJBcVJ6rpFecWJucWleul5yfu4mRkgAfd3BuPSY1SFGAQ5GJR7ehp1zQ4VYE8uKK3MPMUpw MCuJ8GqsBArxpiRWVqUW5ccXleakFh9ilOZgURLnnbnrfYiQQHpiSWp2ampBahFMlomDU6qB 0cpln4/mvfOdCw77KQb/q9l+dOb8S0WcvddiH5p8/3E9KfDjMkabaZeWzGDNTOVS+uNqWxhU +dvTzCl1e2BTmSy3dkFhXZTW8ok51Xlcvv6b3Sq3JvF8Lbr7ukhcseDjvNMWTvceZqdOb07t 5GUs11hze0rtwj0ndrvE7ls51VR+do7EnXuPlViKMxINtZiLihMB8+Z6ohwCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1257 Lines: 41 edid returned by drm_get_edid should be freed. The patch fixes it. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos_hdmi.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c index 99e2864..4a00990 100644 --- a/drivers/gpu/drm/exynos/exynos_hdmi.c +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c @@ -1064,6 +1064,7 @@ static int hdmi_get_modes(struct drm_connector *connector) { struct hdmi_context *hdata = ctx_from_connector(connector); struct edid *edid; + int ret; if (!hdata->ddc_adpt) return -ENODEV; @@ -1079,7 +1080,11 @@ static int hdmi_get_modes(struct drm_connector *connector) drm_mode_connector_update_edid_property(connector, edid); - return drm_add_edid_modes(connector, edid); + ret = drm_add_edid_modes(connector, edid); + + kfree(edid); + + return ret; } static int hdmi_find_phy_conf(struct hdmi_context *hdata, u32 pixel_clock) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/