Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752943AbbGIG1r (ORCPT ); Thu, 9 Jul 2015 02:27:47 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:18646 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751216AbbGIG0V (ORCPT ); Thu, 9 Jul 2015 02:26:21 -0400 X-AuditID: cbfec7f5-f794b6d000001495-24-559e140a334f From: Andrzej Hajda To: inki.dae@samsung.com Cc: Andrzej Hajda , Marek Szyprowski , Kyungmin Park , b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH RESEND 2/6] drm/exynos/mixer: fix interrupt clearing Date: Thu, 09 Jul 2015 08:25:39 +0200 Message-id: <1436423143-22027-3-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1436423143-22027-1-git-send-email-a.hajda@samsung.com> References: <1436423143-22027-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupgluLIzCtJLcpLzFFi42I5/e/4VV0ukXmhBg/O6VncWneO1WLjjPWs Fle+vmezmHR/AovF2aY37BaXd81hs1h75C67A7vH/e7jTB59W1YxenzeJBfAHMVlk5Kak1mW WqRvl8CVse3BS+aCHZwV+x7eZGxgfMDexcjJISFgIjHtUwcLhC0mceHeejYQW0hgKaPEq+f+ XYxcQHYTk0TT2qWMIAk2AU2Jv5tvghWJCEhIzHx1kQnEZha4xyhx+oUGiC0s4CKx8lwXcxcj BweLgKrEwUOCIGFeAWeJud9us0HskpM4eWwyK4jNCVR++08PI8ReZ4kzK3YwT2DkXcDIsIpR NLU0uaA4KT3XSK84Mbe4NC9dLzk/dxMjJHy+7mBceszqEKMAB6MSD2/DzrmhQqyJZcWVuYcY JTiYlUR4NVYChXhTEiurUovy44tKc1KLDzFKc7AoifPO3PU+REggPbEkNTs1tSC1CCbLxMEp 1cDIz6d+SPZfRc7rc6eiZhoq72hQe15Wuc3+cfalfxV37RTObP/3MmMhe4apksqukM32k+OT 7mU9Sz20geXEzusfzy/sCbUO7687FtG7am/ENX6Jlyw3YyaJZNlbHnaaz/V0j3pWAbPYpx06 CXkbvGcG/vszT8S78Zii5ve+U3cXasQcU29+ur5aiaU4I9FQi7moOBEAeCWlUBsCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1416 Lines: 42 The driver used incorrect flags to clear interrupt status. The patch fixes it. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos_mixer.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c index cae98db..0686484 100644 --- a/drivers/gpu/drm/exynos/exynos_mixer.c +++ b/drivers/gpu/drm/exynos/exynos_mixer.c @@ -718,6 +718,9 @@ static irqreturn_t mixer_irq_handler(int irq, void *arg) /* handling VSYNC */ if (val & MXR_INT_STATUS_VSYNC) { + /* vsync interrupt use different bit for read and clear */ + val |= MXR_INT_CLEAR_VSYNC; + /* interlace scan need to check shadow register */ if (ctx->interlace) { base = mixer_reg_read(res, MXR_GRAPHIC_BASE(0)); @@ -743,11 +746,6 @@ static irqreturn_t mixer_irq_handler(int irq, void *arg) out: /* clear interrupts */ - if (~val & MXR_INT_EN_VSYNC) { - /* vsync interrupt use different bit for read and clear */ - val &= ~MXR_INT_EN_VSYNC; - val |= MXR_INT_CLEAR_VSYNC; - } mixer_reg_write(res, MXR_INT_STATUS, val); spin_unlock(&res->reg_slock); -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/