Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751560AbbGIHcG (ORCPT ); Thu, 9 Jul 2015 03:32:06 -0400 Received: from mail-am1on0071.outbound.protection.outlook.com ([157.56.112.71]:37280 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750977AbbGIHbz convert rfc822-to-8bit (ORCPT ); Thu, 9 Jul 2015 03:31:55 -0400 From: Noam Camus To: Vineet Gupta , "linux-serial@vger.kernel.org" CC: "linux-kernel@vger.kernel.org" , "Greg Kroah-Hartman" , Jiri Slaby , Peter Hurley , Rob Herring , "Kevin Cernekee" Subject: RE: [PATCH REBASED RESEND] tty/early: make serial8250_early_{in,out} static again Thread-Topic: [PATCH REBASED RESEND] tty/early: make serial8250_early_{in,out} static again Thread-Index: AQHQug9yVrHoKpEb/kS+BcJdEcezQp3StPnQ Date: Thu, 9 Jul 2015 07:31:52 +0000 Message-ID: References: <1435145184-32303-1-git-send-email-vgupta@synopsys.com> <1436422838-4512-1-git-send-email-vgupta@synopsys.com> In-Reply-To: <1436422838-4512-1-git-send-email-vgupta@synopsys.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: synopsys.com; dkim=none (message not signed) header.d=none; x-originating-ip: [212.179.42.66] x-microsoft-exchange-diagnostics: 1;DB4PR02MB272;5:USoXMXGM7hZWTFWh7ItPnZ+7Hm6DSk/RzUEhZ3ISKmQ2u0qaw19qSrYe+dFv1Am1I+7h1ilJIuEe3AigEJH57R0zt45Wo6R8oUiGUd2UAazhfYCyUdp0HYIJC2aoAxC4pc0ki3N0+bUdca5yP5t8XA==;24:2zRV2M/0XkYc/YCBpPE6Dlv0UYurLkfgBKyoOzcZPCBbMiuXsIvtU6sMyR2rLRt+BsIEycbWMxwkaHWAbHf7MGFhHv+cYMSsosU88kOHj+A=;20:FHaAQ/kGKITO+Y9BpEORQfH/T3w5TfnmR38V6OgeYx6LRTxZtwvE9ethy3WXUFjDxwMp0WTgynj4C/7+F6x0rw== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB4PR02MB272; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:DB4PR02MB272;BCL:0;PCL:0;RULEID:;SRVR:DB4PR02MB272; x-forefront-prvs: 0632519F33 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(377454003)(51704005)(19580395003)(74316001)(106116001)(5001960100002)(77096005)(66066001)(102836002)(189998001)(19580405001)(5003600100002)(2950100001)(2900100001)(92566002)(76576001)(77156002)(50986999)(76176999)(54356999)(62966003)(2501003)(86362001)(46102003)(122556002)(5001770100001)(40100003)(5002640100001)(2656002)(87936001)(33656002)(142933001)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB4PR02MB272;H:DB4PR02MB272.eurprd02.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: ezchip.com X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jul 2015 07:31:52.6601 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 0fc16e0a-3cd3-4092-8b2f-0a42cff122c3 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR02MB272 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 983 Lines: 20 > From: Vineet Gupta [mailto:Vineet.Gupta1@synopsys.com] > Sent: Thursday, July 09, 2015 9:21 AM > > Commit ed71871bed719 ("tty/8250_early: Turn serial_in/serial_out into weak symbols") made these > routines weak to allow platform specific Big endian override > > However recent updates to core, specifically ebc5e20082 ("serial: > of_serial: Support big-endian register accesses") and 6e63be3fee14 > ("serial: earlycon: Add support for big-endian MMIO accesses") means that round about way to override > the early serial accessors is no longer needed. As author of commit ed71871bed719 my original problem is now solved in more generic way and there is no more need for the __weak attribute on these two early serial accessors. ACK -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/