Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752624AbbGIIsH (ORCPT ); Thu, 9 Jul 2015 04:48:07 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:33554 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752561AbbGIIrw (ORCPT ); Thu, 9 Jul 2015 04:47:52 -0400 MIME-Version: 1.0 In-Reply-To: <1435552407-39924-1-git-send-email-maninder1.s@samsung.com> References: <1435552407-39924-1-git-send-email-maninder1.s@samsung.com> From: Oded Gabbay Date: Thu, 9 Jul 2015 11:47:21 +0300 Message-ID: Subject: Re: [RFC][PATCH 1/1] drm/amdkfd: Remove redundant pdd validation To: Maninder Singh Cc: David Airlie , Maling list - DRI developers , "Linux-Kernel@Vger. Kernel. Org" , pankaj.m@samsung.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1531 Lines: 45 On Mon, Jun 29, 2015 at 7:33 AM, Maninder Singh wrote: > > pdd is already dereferenced before this check. > So it is redundtant to validate pdd here. > > Signed-off-by: Maninder Singh > --- > drivers/gpu/drm/amd/amdkfd/kfd_process.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c b/drivers/gpu/drm/amd/amdkfd/kfd_process.c > index 8a1f999..4dbc4e5 100644 > --- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c > @@ -431,8 +431,7 @@ void kfd_unbind_process_from_device(struct kfd_dev *dev, unsigned int pasid) > * We don't call amd_iommu_unbind_pasid() here > * because the IOMMU called us. > */ > - if (pdd) > - pdd->bound = false; > + pdd->bound = false; > > mutex_unlock(&p->mutex); > } > -- > 1.7.9.5 > Hi Maninder, You are correct pdd was already dereferenced so this check is redundant. However, I think a better patch would be to move the check to where pdd is first acquired (a few lines above it), because I don't see there any check. Could you please do that and resend the patch ? Use latest v4.2-rc1 label from Linus please. Thansk, Oded -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/