Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752009AbbGIKHj (ORCPT ); Thu, 9 Jul 2015 06:07:39 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:36092 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751014AbbGIKHb (ORCPT ); Thu, 9 Jul 2015 06:07:31 -0400 Date: Thu, 9 Jul 2015 12:07:27 +0200 From: Jiri Pirko To: Jan Blunck Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] team: set IFF_SLAVE on team ports Message-ID: <20150709100727.GE2270@nanopsycho.orion> References: <1436435914-8903-1-git-send-email-jblunck@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436435914-8903-1-git-send-email-jblunck@infradead.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1615 Lines: 47 Thu, Jul 09, 2015 at 11:58:34AM CEST, jblunck@infradead.org wrote: >The code in net/ipv6/addrconf.c:addrconf_notify() tests for IFF_SLAVE to >decide if it should start the address configuration. Since team ports >shouldn't get link-local addresses assigned lets set IFF_SLAVE when linking >a port to the team master. I don't want to use IFF_SLAVE in team. Other master-slave devices are not using that as well, for example bridge, ovs, etc. I think that this should be fixed in addrconf_notify. It should lookup if there is a master on top and bail out in that case. > >Signed-off-by: Jan Blunck >--- > drivers/net/team/team.c | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c >index daa054b..4cd02c8 100644 >--- a/drivers/net/team/team.c >+++ b/drivers/net/team/team.c >@@ -1086,6 +1086,7 @@ static int team_upper_dev_link(struct net_device *dev, > err = netdev_master_upper_dev_link(port_dev, dev); > if (err) > return err; >+ port_dev->flags |= IFF_SLAVE; > port_dev->priv_flags |= IFF_TEAM_PORT; > return 0; > } >@@ -1094,6 +1095,7 @@ static void team_upper_dev_unlink(struct net_device *dev, > struct net_device *port_dev) > { > netdev_upper_dev_unlink(port_dev, dev); >+ port_dev->flags &= ~IFF_SLAVE; > port_dev->priv_flags &= ~IFF_TEAM_PORT; > } > >-- >2.1.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/