Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751934AbbGIK5r (ORCPT ); Thu, 9 Jul 2015 06:57:47 -0400 Received: from mail-oi0-f45.google.com ([209.85.218.45]:35389 "EHLO mail-oi0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750799AbbGIK5k (ORCPT ); Thu, 9 Jul 2015 06:57:40 -0400 MIME-Version: 1.0 In-Reply-To: <1436437783.2682.104.camel@perches.com> References: <20150623064140.GA18300@kroah.com> <20150708135402.GA13432@amd> <1436437783.2682.104.camel@perches.com> Date: Thu, 9 Jul 2015 12:57:39 +0200 X-Google-Sender-Auth: lxLzpnVDDmQWTZUtbbsz4nFlL3Q Message-ID: Subject: Re: kdbus: to merge or not to merge? From: Geert Uytterhoeven To: Joe Perches Cc: Pavel Machek , Greg KH , Andy Lutomirski , Linus Torvalds , "linux-kernel@vger.kernel.org" , David Herrmann , Djalal Harouni , Havoc Pennington , "Eric W. Biederman" , One Thousand Gnomes , Tom Gundersen , Daniel Mack Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1538 Lines: 40 On Thu, Jul 9, 2015 at 12:29 PM, Joe Perches wrote: > On Thu, 2015-07-09 at 10:39 +0200, Geert Uytterhoeven wrote: >> On Wed, Jul 8, 2015 at 3:54 PM, Pavel Machek wrote: >> > Apparently, new tools are needed in the community, as normal review >> > comments did not stop drivers/android/binder.c merge. >> > >> > For example binder_transaction does not exactly look like a kernel >> > code, "TODO: fput" does not really invoke confidence, and amount of >> > BUG_ON()s is quite amazing... >> >> Amazingly, checkpatch (without --strict) only complains about long lines. >> >> Seems like the test for "BUG" is (and always has been) commented out... > > Maybe (requires --strict when scanning files) > --- > scripts/checkpatch.pl | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) Thanks! Detected 31 occurrences (+ 1 commented out), shudder... Tested-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/