Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752857AbbGILDY (ORCPT ); Thu, 9 Jul 2015 07:03:24 -0400 Received: from mail-lb0-f177.google.com ([209.85.217.177]:34161 "EHLO mail-lb0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750998AbbGILDP (ORCPT ); Thu, 9 Jul 2015 07:03:15 -0400 Subject: Re: [RFC Patch V1 02/12] MIPS, PCI: Use for_pci_msi_entry() to access MSI device list To: Jiang Liu , Bjorn Helgaas , Thomas Gleixner , Ingo Molnar , Grant Likely , Marc Zyngier , Stuart Yoder , Yijing Wang , Borislav Petkov , Ralf Baechle References: <1436428847-8886-1-git-send-email-jiang.liu@linux.intel.com> <1436428847-8886-3-git-send-email-jiang.liu@linux.intel.com> Cc: Tony Luck , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@linux-mips.org From: Sergei Shtylyov Message-ID: <559E54EE.7090504@cogentembedded.com> Date: Thu, 9 Jul 2015 14:03:10 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <1436428847-8886-3-git-send-email-jiang.liu@linux.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1154 Lines: 36 Hello. On 7/9/2015 11:00 AM, Jiang Liu wrote: > Use accessor for_pci_msi_entry() to access MSI device list, so we could Maybe for_each_pci_msi_entry()? > easily move msi_list from struct pci_dev into struct device later. > Signed-off-by: Jiang Liu > --- > arch/mips/pci/msi-octeon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > diff --git a/arch/mips/pci/msi-octeon.c b/arch/mips/pci/msi-octeon.c > index cffaaf4aae3c..2a5bb849b10e 100644 > --- a/arch/mips/pci/msi-octeon.c > +++ b/arch/mips/pci/msi-octeon.c > @@ -200,7 +200,7 @@ int arch_setup_msi_irqs(struct pci_dev *dev, int nvec, int type) > if (type == PCI_CAP_ID_MSI && nvec > 1) > return 1; > > - list_for_each_entry(entry, &dev->msi_list, list) { > + for_each_pci_msi_entry(entry, dev) { > ret = arch_setup_msi_irq(dev, entry); > if (ret < 0) > return ret; WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/