Date: Thu, 9 Jul 2015 13:36:41 +0200
From: Pavel Machek <pavel@ucw.cz>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Greg KH <gregkh@linuxfoundation.org>,
        Andy Lutomirski <luto@amacapital.net>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        David Herrmann <dh.herrmann@gmail.com>,
        Djalal Harouni <tixxdz@opendz.org>,
        Havoc Pennington <havoc.pennington@gmail.com>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
        Tom Gundersen <teg@jklm.no>, Daniel Mack <daniel@zonque.org>
Subject: Re: kdbus: to merge or not to merge?
Message-ID: <20150709113641.GA15488@amd>
References: <CALCETrW5sdcwM4zoX7BQdf+a2fWgQhd6rPDg8br0FU7Xy-2ZhQ@mail.gmail.com>
 <20150623064140.GA18300@kroah.com>
 <20150708135402.GA13432@amd>
 <CAMuHMdVMEYeW1e28BTGYPT7mKOSaZTScE_-tXt6_rAEvKDsGPQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAMuHMdVMEYeW1e28BTGYPT7mKOSaZTScE_-tXt6_rAEvKDsGPQ@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1248
Lines: 31

On Thu 2015-07-09 10:39:58, Geert Uytterhoeven wrote:
> On Wed, Jul 8, 2015 at 3:54 PM, Pavel Machek <pavel@ucw.cz> wrote:
> > Apparently, new tools are needed in the community, as normal review
> > comments did not stop drivers/android/binder.c merge.
> >
> > For example binder_transaction does not exactly look like a kernel
> > code, "TODO: fput" does not really invoke confidence, and ammount of
> > BUG_ON()s is quite amazing...
> 
> Amazingly, checkpatch (without --strict) only complains about long lines.

Well, checkpatch only tells half of storry.

Anyway worst problem is that there's no documentation of kernel<->user
interface binder provides, making understanding it hard/impossible.

Closest to documentation pointer is:

 * Based on, but no longer compatible with, the original
 * OpenBinder.org binder driver interface, which is:
  
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/