Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752701AbbGILzn (ORCPT ); Thu, 9 Jul 2015 07:55:43 -0400 Received: from down.free-electrons.com ([37.187.137.238]:46274 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751172AbbGILzg (ORCPT ); Thu, 9 Jul 2015 07:55:36 -0400 Date: Thu, 9 Jul 2015 13:55:33 +0200 From: Alexandre Belloni To: Vaibhav Hiremath Cc: linux-arm-kernel@lists.infradead.org, Chao Xie , Alessandro Zummo , "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" , open list Subject: Re: [RESEND PATCH-v2] rtc: 88pm80x: add device tree support Message-ID: <20150709115533.GY3127@piout.net> References: <1436424952-29680-1-git-send-email-vaibhav.hiremath@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436424952-29680-1-git-send-email-vaibhav.hiremath@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1057 Lines: 33 Hi, On 09/07/2015 at 12:25:51 +0530, Vaibhav Hiremath wrote : > Along with DT support, this patch also cleans up the unnecessary > code around 'rtc_wakeup' initialization. > > Signed-off-by: Chao Xie > Signed-off-by: Vaibhav Hiremath No need to resend, I'll take it. I'm current busy with other things and it is still early in the development cycle. > - if (pm80x_pdata) { > - pdata = pm80x_pdata->rtc; > - if (pdata) > - info->rtc_dev->dev.platform_data = &pdata->rtc_wakeup; > - } > + /* remeber whether this power up is caused by PMIC RTC or not */ I'll fix that typo... > + info->rtc_dev->dev.platform_data = &pdata->rtc_wakeup; > -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/