Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752956AbbGIMIk (ORCPT ); Thu, 9 Jul 2015 08:08:40 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:36777 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751307AbbGIMIj (ORCPT ); Thu, 9 Jul 2015 08:08:39 -0400 Date: Thu, 9 Jul 2015 14:08:35 +0200 From: Michal Hocko To: Vladimir Davydov Cc: Johannes Weiner , Andrew Morton , Tejun Heo , Oleg Nesterov , Greg Thelen , KAMEZAWA Hiroyuki , KOSAKI Motohiro , linux-mm@kvack.org, LKML Subject: Re: [PATCH 4/8] memcg, mm: move mem_cgroup_select_victim_node into vmscan Message-ID: <20150709120835.GF13872@dhcp22.suse.cz> References: <1436358472-29137-1-git-send-email-mhocko@kernel.org> <1436358472-29137-5-git-send-email-mhocko@kernel.org> <20150708160159.GD2436@esperanza> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150708160159.GD2436@esperanza> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1701 Lines: 40 On Wed 08-07-15 19:01:59, Vladimir Davydov wrote: > On Wed, Jul 08, 2015 at 02:27:48PM +0200, Michal Hocko wrote: > > From: Michal Hocko > > > > We currently have only one caller of mem_cgroup_select_victim_node which > > is sitting in mm/vmscan.c and which is already wrapped by CONFIG_MEMCG > > ifdef. Now that we have struct mem_cgroup visible outside of > > mm/memcontrol.c we can move the function and its dependencies there. > > This even shrinks the code size by few bytes: > > > > text data bss dec hex filename > > 478509 65806 26384 570699 8b54b mm/built-in.o.before > > 478445 65806 26384 570635 8b50b mm/built-in.o.after > > > > Signed-off-by: Michal Hocko > > I dislike this patch, because I don't see any reason why logic specific > to per memcg reclaim should live in the file representing the global > reclaim path. Well the idea was that mem_cgroup_select_victim_node is specific to try_to_free_mem_cgroup_pages. It is basically a split up of otherwise large function for readability. Same applies to mem_cgroup_may_update_nodemask. Having that code together makes some sense to me. On the other hand I do agree that at least test_mem_cgroup_node_reclaimable is generally reusable and so it shouldn't be in vmscan. I can move it back to memcontrol but that leaves the generated code much worse. Fair enough then, I will drop this patch. -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/