Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752846AbbGIOdY (ORCPT ); Thu, 9 Jul 2015 10:33:24 -0400 Received: from mail.kernel.org ([198.145.29.136]:49791 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750894AbbGIOdO (ORCPT ); Thu, 9 Jul 2015 10:33:14 -0400 Date: Thu, 9 Jul 2015 22:32:57 +0800 From: Shawn Guo To: Philippe Reynes Cc: a.zummo@towertech.it, alexandre.belloni@free-electrons.com, shawn.guo@linaro.org, kernel@pengutronix.de, linux@arm.linux.org.uk, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 6/7] imx27: dt: add support of internal rtc Message-ID: <20150709143257.GJ23464@tiger> References: <1435965320-1478-1-git-send-email-tremyfr@gmail.com> <1435965320-1478-7-git-send-email-tremyfr@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1435965320-1478-7-git-send-email-tremyfr@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1604 Lines: 51 On Sat, Jul 04, 2015 at 01:15:19AM +0200, Philippe Reynes wrote: > Add support of internal rtc on imx27. > > Signed-off-by: Philippe Reynes > --- > arch/arm/boot/dts/imx27.dtsi | 10 ++++++++++ > 1 files changed, 10 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi > index b69be5c..38e6e84 100644 > --- a/arch/arm/boot/dts/imx27.dtsi > +++ b/arch/arm/boot/dts/imx27.dtsi > @@ -144,6 +144,16 @@ > clock-names = "ipg", "per"; > }; > > + rtc: rtc@10007000 { > + compatible = "fsl,imx21-rtc"; > + reg = <0x10007000 0x1000>; > + interrupts = <22>; > + clocks = <&clks IMX27_CLK_CKIL>, > + <&clks IMX27_CLK_RTC_IPG_GATE>; > + clock-names = "rtc", "ipg"; > + status = "disabled"; It has neither pin-out nor board level configuration. For such device, it makes more sense to drop status = "disabled" and enable the device by default. The bonus point would be that patch #7 in the series can be saved. Shawn > + }; > + > kpp: kpp@10008000 { > compatible = "fsl,imx27-kpp", "fsl,imx21-kpp"; > reg = <0x10008000 0x1000>; > -- > 1.7.4.4 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/