Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752946AbbGIPXC (ORCPT ); Thu, 9 Jul 2015 11:23:02 -0400 Received: from mail-wg0-f52.google.com ([74.125.82.52]:34751 "EHLO mail-wg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751296AbbGIPW5 (ORCPT ); Thu, 9 Jul 2015 11:22:57 -0400 Message-ID: <559E91CD.5020707@linaro.org> Date: Thu, 09 Jul 2015 18:22:53 +0300 From: Georgi Djakov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Srinivas Kandagatla , sboyd@codeaurora.org CC: mturquette@baylibre.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 1/2] clk: qcom: Add support for RPM Clocks References: <1436444310-15108-1-git-send-email-georgi.djakov@linaro.org> <1436444310-15108-2-git-send-email-georgi.djakov@linaro.org> <559E68A9.2020809@linaro.org> In-Reply-To: <559E68A9.2020809@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2145 Lines: 52 Hi Srini, On 07/09/2015 03:27 PM, Srinivas Kandagatla wrote: > > On 09/07/15 13:18, Georgi Djakov wrote: >> This patch adds initial support for clocks controlled by the RPM >> (Resource Power Manager) processor found on some Qualcomm SoCs. >> >> The RPM is a dedicated hardware engine for managing the shared >> SoC resources in order to keep the lowest power profile. It >> communicates with other hardware subsystems via shared memory >> and accepts clock requests, aggregates the requests and turns >> the clocks on/off or scales them on demand. >> >> This work is based on the codeaurora.org driver: >> https://www.codeaurora.org/cgit/quic/la/kernel/msm-3.10/tree/drivers/clk/qcom/clock-rpm.c >> >> Signed-off-by: Georgi Djakov >> --- >> drivers/clk/qcom/Makefile | 1 + >> drivers/clk/qcom/clk-rpm.c | 164 ++++++++++++++++++++++++++++++++++++++++++++ >> drivers/clk/qcom/clk-rpm.h | 137 ++++++++++++++++++++++++++++++++++++ >> 3 files changed, 302 insertions(+) >> create mode 100644 drivers/clk/qcom/clk-rpm.c >> create mode 100644 drivers/clk/qcom/clk-rpm.h >> >> diff --git a/drivers/clk/qcom/Makefile b/drivers/clk/qcom/Makefile >> index 50b337a24a87..4d14a73ee4ed 100644 >> --- a/drivers/clk/qcom/Makefile >> +++ b/drivers/clk/qcom/Makefile >> @@ -8,6 +8,7 @@ clk-qcom-y += clk-rcg2.o >> clk-qcom-y += clk-branch.o >> clk-qcom-y += clk-regmap-divider.o >> clk-qcom-y += clk-regmap-mux.o >> +clk-qcom-y += clk-rpm.o > > Is this generic enough to be built by default. It will break builds on A family whose rpm clocks are not based on SMD. > > IMO, this should be either renamed to clk-rpm-smd.* or only built with SOC's which support rpm-clks based on SMD. > There is no A-family RPM clock support in the upstream kernel yet, but sure, you are right, we want to build only what is actually used. Thanks for the suggestion! BR, Georgi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/