MIME-Version: 1.0
In-Reply-To: <20150709100727.GE2270@nanopsycho.orion>
References: <1436435914-8903-1-git-send-email-jblunck@infradead.org>
	<20150709100727.GE2270@nanopsycho.orion>
Date: Thu, 9 Jul 2015 17:36:55 +0200
Message-ID: <CALe+Z03R_MPcgUSa8xoMeT5Sv3z8KwFhrtoYYzON=prfR-7hxQ@mail.gmail.com>
Subject: Re: [PATCH] team: set IFF_SLAVE on team ports
From: Jan Blunck <jblunck@infradead.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: LKML <linux-kernel@vger.kernel.org>, netdev@vger.kernel.org
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1412
Lines: 36

On Thu, Jul 9, 2015 at 12:07 PM, Jiri Pirko <jiri@resnulli.us> wrote:
> Thu, Jul 09, 2015 at 11:58:34AM CEST, jblunck@infradead.org wrote:
>>The code in net/ipv6/addrconf.c:addrconf_notify() tests for IFF_SLAVE to
>>decide if it should start the address configuration. Since team ports
>>shouldn't get link-local addresses assigned lets set IFF_SLAVE when linking
>>a port to the team master.
>
> I don't want to use IFF_SLAVE in team. Other master-slave devices are
> not using that as well, for example bridge, ovs, etc.
>

Maybe they need to get fixed too. I've used that flag because it is
documented as
a "slave of a load balancer" which describes what a team port is.


> I think that this should be fixed in addrconf_notify. It should lookup
> if there is a master on top and bail out in that case.

There are other virtual interfaces that have a master assigned and want to
participate in IPv6 address configuration.

Unless we want to have a cascade of conditionals testing the priv_flags in
addrconf_notify() this is asking for a new net_device_flags flag.
Maybe something
generic like IFF_L2PORT ?

Thanks,
Jan

[ Jiri, sorry for getting that mail twice ]
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/