Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754102AbbGISff (ORCPT ); Thu, 9 Jul 2015 14:35:35 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:45880 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752918AbbGISf2 (ORCPT ); Thu, 9 Jul 2015 14:35:28 -0400 Date: Thu, 9 Jul 2015 19:35:08 +0100 From: Mark Brown To: Vaibhav Hiremath Cc: linux-arm-kernel@lists.infradead.org, lgirdwood@gmail.com, sameo@linux.intel.com, lee.jones@linaro.org, linux-kernel@vger.kernel.org, Hongyan Song Message-ID: <20150709183508.GN11162@sirena.org.uk> References: <1436445692-10656-1-git-send-email-vaibhav.hiremath@linaro.org> <1436445692-10656-2-git-send-email-vaibhav.hiremath@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lWpfK6zjveGYW7HN" Content-Disposition: inline In-Reply-To: <1436445692-10656-2-git-send-email-vaibhav.hiremath@linaro.org> X-Cookie: Stay together, drag each other down. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 1/3] regulator: 88pm800: Add 88pm860 regulator support X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1794 Lines: 56 --lWpfK6zjveGYW7HN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jul 09, 2015 at 06:11:30PM +0530, Vaibhav Hiremath wrote: > +/* dummy table */ > +static const struct regulator_linear_range buck_volt_range_dummy[] = { > +}; I don't understand this, it certainly doesn't look very healthy and would need more documentation. > +/* dummy table */ > +static const unsigned int ldo_volt_table_dummy[] = { > +}; Likewise. > - ret = of_regulator_match(&pdev->dev, np, > - pm800_regulator_matches, > - ARRAY_SIZE(pm800_regulator_matches)); > - if (ret < 0) > + ret = of_regulator_match(&pdev->dev, np, *regulator_matches, range); > + if (ret < 0) { > + dev_err(&pdev->dev, "Error parsing regulator init data: %d\n", ret); > return ret; > + } Can you convert the driver to use the more modern core matching code (setting of_match in the driver struct)? That should simplify this change. --lWpfK6zjveGYW7HN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVnr7bAAoJECTWi3JdVIfQjc8H/iyhcKVo9ZedaXdmaMlah25O /WAxwsakMYW0K4DhVuWSyfsLFRVowmaKu35vAXbiJcQnJF64QAzfB9Dcf22KmKW2 TAUUDzJUtBREMALTx0RpUJy0fTml03OpshzENx9GmBH/V8GI/+nizuwpQTIMuxBW bgXDLxCiGMWoG/ZQerYVfF78onyvV7TWIbG+D+f3mxg840mmrPHJdEbdJMJ9NJoB Hexef2qy9n9NKW7KAhmevIvicMUe1OLIVFaynQsSeQdkQSqL7ifpaA4prbQg4wf8 dNZjm2Xh5Z35BcrTL4FZuKUxrKhk3nsXOHwEXAzyPpOHHOdtKnciHrCFnipcl4c= =Z5e5 -----END PGP SIGNATURE----- --lWpfK6zjveGYW7HN-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/