Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753915AbbGISiv (ORCPT ); Thu, 9 Jul 2015 14:38:51 -0400 Received: from mail-wi0-f173.google.com ([209.85.212.173]:37844 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752210AbbGISil (ORCPT ); Thu, 9 Jul 2015 14:38:41 -0400 MIME-Version: 1.0 In-Reply-To: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <559D8874.7090407@users.sourceforge.net> Date: Thu, 9 Jul 2015 14:38:40 -0400 Message-ID: Subject: Re: [PATCH] i2c-HID: Delete unnecessary checks before the function call "gpiod_put" From: Benjamin Tissoires To: Jiri Kosina Cc: SF Markus Elfring , linux-input , Linux Kernel Mailing List , kernel-janitors@vger.kernel.org, Julia Lawall , Mika Westerberg Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1391 Lines: 36 On Thu, Jul 9, 2015 at 8:34 AM, Jiri Kosina wrote: > On Wed, 8 Jul 2015, SF Markus Elfring wrote: > >> From: Markus Elfring >> Date: Wed, 8 Jul 2015 22:12:25 +0200 >> >> The gpiod_put() function performs also input parameter validation >> by forwarding its single input pointer to the gpiod_free() function. >> Thus the test around the calls is not needed. >> >> This issue was detected by using the Coccinelle software. >> >> Signed-off-by: Markus Elfring > > As Dan correctly pointed out, this is not as straightforward as it might > seem on a firsr sight, because there is a WARN_ON() that might start > triggering in case of !ihid->desc. > > Adding Benjamin. I am not applying this without his Ack. > I think the gpiod case is the exception rather than the common rule (most i2c-hid device we saw until recently were using irqs, not gpios). So if I understand correctly, removing the check on ihid->desc would raise a warning for most devices. This is IMO not a good thing, so I would say NACK. Mika might have a different opinion though. Cheers, Benjamin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/