Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752639AbbGISvK (ORCPT ); Thu, 9 Jul 2015 14:51:10 -0400 Received: from mga01.intel.com ([192.55.52.88]:34562 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750894AbbGISvF (ORCPT ); Thu, 9 Jul 2015 14:51:05 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,441,1432623600"; d="scan'208";a="759267728" Message-ID: <559EC297.3030901@linux.intel.com> Date: Thu, 09 Jul 2015 11:51:03 -0700 From: Arjan van de Ven User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Andy Lutomirski , x86@kernel.org, linux-kernel@vger.kernel.org CC: Oleg Nesterov , Kees Cook , Peter Zijlstra , Borislav Petkov , Linus Torvalds , Austin S Hemmelgarn , Brian Gerst , Matthew Garrett Subject: Re: [PATCH] x86/kconfig/32: Make CONFIG_VM86 default to n and remove EXPERT References: In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1142 Lines: 27 On 7/9/2015 11:40 AM, Andy Lutomirski wrote: > VM86 is entirely broken if ptrace, syscall auditing, or NOHZ_FULL is > in use. The code is a big undocumented mess, it's a real PITA to > test, and it looks like a big chunk of vm86_32.c is dead code. It > also plays awful games with the entry asm. > > No one should be using it anyway. Use DOSBOX or KVM instead. > > Let's accelerate its slow death. Remove it from EXPERT and default > it to n. Distros should not enable it. In the unlikely event that > some user needs it, they can easily re-enable it. > > I've confirmed that 'make oldconfig' will set leave it set to y, so > there should be little or no unexpected breakage from this change. > I would rather do BOTH the default n AND the EXPERT e.g. the existing hurdle of EXPERT combined with the default (e.g. off entirely in non-EXPERT, and with EXPERT it is sill defaulting to =n) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/