Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753392AbbGITB0 (ORCPT ); Thu, 9 Jul 2015 15:01:26 -0400 Received: from mail-la0-f54.google.com ([209.85.215.54]:33731 "EHLO mail-la0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751312AbbGITBU (ORCPT ); Thu, 9 Jul 2015 15:01:20 -0400 MIME-Version: 1.0 In-Reply-To: <559EC297.3030901@linux.intel.com> References: <559EC297.3030901@linux.intel.com> From: Andy Lutomirski Date: Thu, 9 Jul 2015 12:00:59 -0700 Message-ID: Subject: Re: [PATCH] x86/kconfig/32: Make CONFIG_VM86 default to n and remove EXPERT To: Arjan van de Ven Cc: Andy Lutomirski , X86 ML , "linux-kernel@vger.kernel.org" , Oleg Nesterov , Kees Cook , Peter Zijlstra , Borislav Petkov , Linus Torvalds , Austin S Hemmelgarn , Brian Gerst , Matthew Garrett Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1446 Lines: 42 On Thu, Jul 9, 2015 at 11:51 AM, Arjan van de Ven wrote: > On 7/9/2015 11:40 AM, Andy Lutomirski wrote: >> >> VM86 is entirely broken if ptrace, syscall auditing, or NOHZ_FULL is >> in use. The code is a big undocumented mess, it's a real PITA to >> test, and it looks like a big chunk of vm86_32.c is dead code. It >> also plays awful games with the entry asm. >> >> No one should be using it anyway. Use DOSBOX or KVM instead. >> >> Let's accelerate its slow death. Remove it from EXPERT and default >> it to n. Distros should not enable it. In the unlikely event that >> some user needs it, they can easily re-enable it. >> >> I've confirmed that 'make oldconfig' will set leave it set to y, so >> there should be little or no unexpected breakage from this change. >> > > I would rather do BOTH the default n AND the EXPERT > > e.g. the existing hurdle of EXPERT combined with the default > (e.g. off entirely in non-EXPERT, and with EXPERT it is sill defaulting to > =n) > > I figured we could do this for a release or two, then move it into EXPERT. But I'd be fine with your suggestion, too. Ingo, Linus? --Andy -- Andy Lutomirski AMA Capital Management, LLC -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/