Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753099AbbGITFA (ORCPT ); Thu, 9 Jul 2015 15:05:00 -0400 Received: from mail-la0-f67.google.com ([209.85.215.67]:33450 "EHLO mail-la0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752179AbbGITE5 convert rfc822-to-8bit (ORCPT ); Thu, 9 Jul 2015 15:04:57 -0400 MIME-Version: 1.0 In-Reply-To: <20150708200108.GC10037@birch.djwong.org> References: <1436385075-22559-1-git-send-email-laurent.navet@gmail.com> <20150708200108.GC10037@birch.djwong.org> Date: Thu, 9 Jul 2015 21:04:55 +0200 Message-ID: Subject: Re: [PATCH] ext4 crypto: remove unneeded assignation From: Laurent Navet To: "Darrick J. Wong" Cc: tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1794 Lines: 52 Make sense, I send a v2, thank's 2015-07-08 22:01 UTC+02:00, Darrick J. Wong : > On Wed, Jul 08, 2015 at 09:51:15PM +0200, Laurent Navet wrote: >> Return value of ext4_derive_key_aes() is stored but never used before >> being overwritten. >> Also fix coverity CID 1309760. >> >> Signed-off-by: Laurent Navet >> --- >> fs/ext4/crypto_key.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/fs/ext4/crypto_key.c b/fs/ext4/crypto_key.c >> index 442d24e..92f9172 100644 >> --- a/fs/ext4/crypto_key.c >> +++ b/fs/ext4/crypto_key.c >> @@ -218,7 +218,7 @@ retry: >> BUILD_BUG_ON(EXT4_AES_128_ECB_KEY_SIZE != >> EXT4_KEY_DERIVATION_NONCE_SIZE); >> BUG_ON(master_key->size != EXT4_AES_256_XTS_KEY_SIZE); >> - res = ext4_derive_key_aes(ctx.nonce, master_key->raw, >> + ext4_derive_key_aes(ctx.nonce, master_key->raw, >> raw_key); > > I don't think it's a good idea to drop the error code on the floor and keep > going as if nothing bad had happened. > > --D > >> got_key: >> ctfm = crypto_alloc_ablkcipher(cipher_str, 0, 0); >> -- >> 2.1.4 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- « On ne résout pas un problème avec les modes de pensée qui l’ont engendré. » « You cannot solve current problems with current thinking. Current problems are the result of current thinking » -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/