Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753489AbbGITF7 (ORCPT ); Thu, 9 Jul 2015 15:05:59 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:45916 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751215AbbGITF6 (ORCPT ); Thu, 9 Jul 2015 15:05:58 -0400 Date: Thu, 9 Jul 2015 20:05:47 +0100 From: Mark Brown To: Vaibhav Hiremath Cc: linux-arm-kernel@lists.infradead.org, lgirdwood@gmail.com, sameo@linux.intel.com, lee.jones@linaro.org, linux-kernel@vger.kernel.org Message-ID: <20150709190547.GQ11162@sirena.org.uk> References: <1436445692-10656-1-git-send-email-vaibhav.hiremath@linaro.org> <1436445692-10656-4-git-send-email-vaibhav.hiremath@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="arh1ZL78woflSoTn" Content-Disposition: inline In-Reply-To: <1436445692-10656-4-git-send-email-vaibhav.hiremath@linaro.org> X-Cookie: Stay together, drag each other down. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 3/3] regulator: 88pm800: Add dev_info to show probe success status X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1484 Lines: 40 --arh1ZL78woflSoTn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jul 09, 2015 at 06:11:32PM +0530, Vaibhav Hiremath wrote: > This patch adds dev_info line at the end of probe function, to > clearly put status of regulator probe on console. Useful during > development, specially to check bootlog. > + dev_info(&pdev->dev, "Regulator registered ...\n"); > return 0; No, this is pure noise - all you're doing is slowing down boot for users with no content. Think about what would happen if every driver did this. The core already displays the constraints when things are registered. --arh1ZL78woflSoTn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVnsYKAAoJECTWi3JdVIfQAtYH/00hHxhnRBzhCGbQEaCmUAkV Z0T+fgAz/ZimWfUHuXguN/ebltRTlwOYxR/nGig8DJcxsl/nw2al1cGCuKkIbT9L 8BFUIlYFfiGFax5XY0jimM/fOKxTBBjsDLQZQb46pM9vo54wxTlyPUqaRb+oZPl2 LAL1ewk6RjpV9peMww1Z4T9OrixZMvDa7G600InyTL7I41Pmr7mPU/8j3UR0MbAI k4pTqS02i3fBOFD0beMomne/KlHnoJ1ji7n1mfuOungu06n29V5APMj8XkgCjZnh OTjHfq3D1Z12DYOvDUB/HKxI0eT5WEH6SzSN9NI1IaRkH16lLFml3gxqXjxYLk4= =Bht5 -----END PGP SIGNATURE----- --arh1ZL78woflSoTn-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/